Skip to content

fix(opencode): preserve prompt tool enables with empty agent permissions#17064

Merged
rekram1-node merged 1 commit intoanomalyco:devfrom
jquense:jq/fix-prompt-permissions
Mar 16, 2026
Merged

fix(opencode): preserve prompt tool enables with empty agent permissions#17064
rekram1-node merged 1 commit intoanomalyco:devfrom
jquense:jq/fix-prompt-permissions

Conversation

@jquense
Copy link
Contributor

@jquense jquense commented Mar 11, 2026

Issue for this PR

Closes #17063

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

When an agent has permission: {}, prompt-level tool enables can be dropped before the model request is built.

This PR applies session/prompt permission overrides in the same pre-request filtering path that decides which tools are exposed to the model, and adds a regression test for the tools: { question: true } case.

How did you verify your code works?

  • added regression coverage in packages/opencode/test/session/llm.test.ts
  • reproduced the bug with a local SDK repro script
  • confirmed the repro succeeds against the local dev server with this change
Repro script used for testing

packages/sdk/js/example/question-permission-repro.ts

import { createOpencodeClient } from "@opencode-ai/sdk/v2"
import { spawn } from "node:child_process"

const key = process.env.ANTHROPIC_API_KEY

if (!key) {
  throw new Error("Set ANTHROPIC_API_KEY before running this repro")
}

const port = 4100 + Math.floor(Math.random() * 1000)
const proc = spawn("bun", ["run", "dev", "--", "serve", `--hostname=127.0.0.1`, `--port=${port}`], {
  cwd: new URL("../../../../", import.meta.url),
  env: {
    ...process.env,
    OPENCODE_CONFIG_CONTENT: JSON.stringify({
      enabled_providers: ["anthropic"],
      provider: {
        anthropic: {
          options: {
            apiKey: key,
          },
        },
      },
      agent: {
        repro: {
          mode: "primary",
          model: "anthropic/claude-sonnet-4-5-20250929",
          permission: {},
        },
      },
    }),
  },
})

proc.stdout?.pipe(process.stdout)
proc.stderr?.pipe(process.stderr)

const url = await new Promise<string>((resolve, reject) => {
  let out = ""
  const timeout = setTimeout(() => done(new Error(`timed out waiting for dev server\n${out}`)), 15000)
  const done = (err?: Error) => {
    clearTimeout(timeout)
    proc.stdout?.off("data", onStdout)
    proc.stderr?.off("data", onStderr)
    proc.off("error", onError)
    proc.off("exit", onExit)
    if (err) reject(err)
  }
  const onStdout = (chunk: Buffer) => {
    out += chunk.toString()
    for (const line of out.split("\n")) {
      const match = line.match(/opencode server listening on\s+(https?:\/\/\S+)/)
      if (!match) continue
      done()
      resolve(match[1]!)
      return
    }
  }
  const onStderr = (chunk: Buffer) => {
    out += chunk.toString()
  }
  const onError = (err: Error) => done(err)
  const onExit = (code: number | null) => done(new Error(`dev server exited early: ${code}\n${out}`))
  proc.stdout?.on("data", onStdout)
  proc.stderr?.on("data", onStderr)
  proc.on("error", onError)
  proc.on("exit", onExit)
})

const client = createOpencodeClient({ baseUrl: url })
const session = await client.session.create()
const sessionID = session.data!.id

console.log("session:", sessionID)
console.log("sending prompt")

const result = await client.session.prompt({
  sessionID,
  agent: "repro",
  tools: {
    question: true,
  },
  parts: [
    {
      type: "text",
      text: "do you have a question tool?",
    },
  ],
})

console.log(result.data?.parts?.find((part) => part.type === "text")?.text)

proc.kill()

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions bot added contributor needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Mar 11, 2026
@github-actions
Copy link
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@rekram1-node
Copy link
Collaborator

/review

@github-actions
Copy link
Contributor

lgtm

@rekram1-node rekram1-node merged commit c2ca149 into anomalyco:dev Mar 16, 2026
13 checks passed
ConanXu-math pushed a commit to ConanXu-math/opencode that referenced this pull request Mar 17, 2026
e6qu pushed a commit to e6qu/frankencode that referenced this pull request Mar 18, 2026
…port B3 #17064)

Add permission field to StreamInput and merge it with agent permissions
when computing disabled tools. Forward session.permission from prompt.ts.

Upstream: anomalyco/opencode#17064 (c2ca149)
e6qu added a commit to e6qu/frankencode that referenced this pull request Mar 18, 2026
* fix(vcs): fix inverted HEAD filter in watcher (backport B8 #17829)

The file watcher was ignoring HEAD changes instead of filtering
non-HEAD changes, so branch switches were never detected.

Upstream: anomalyco/opencode#17829 (e5cbecf)
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>

* fix(core): detect context_length_exceeded in API call errors (backport B1 #17748)

Parse response body for error code so providers returning
context_length_exceeded are correctly classified as context overflow.

Upstream: anomalyco/opencode#17748 (e718db6)

* fix(util): log ZodError issues on schema validation failure (backport B5)

Print the specific validation issues alongside the stack trace to make
debugging schema mismatches easier.

* fix(tui): check for selected text in dialog escape handler (backport B7 #16779)

Check getSelectedText() instead of just getSelection() so escape
correctly closes dialogs when a selection object exists but has no text.

Upstream: anomalyco/opencode#16779 (a64f604)

* fix(ui): wrap question option descriptions instead of truncating (backport B6 #17782)

Replace overflow:hidden/text-overflow:ellipsis with overflow-wrap:anywhere
so long descriptions are visible. Remove the now-redundant data-custom override.

Upstream: anomalyco/opencode#17782 (51fcd04)

* fix(opencode): apply message transforms during compaction (backport B2 #17823)

Run Plugin.trigger("experimental.chat.messages.transform") on a
structuredClone of messages before passing them to the compaction model.

Upstream: anomalyco/opencode#17823 (4cb2996)

* fix(opencode): forward session permission ruleset to LLM stream (backport B3 #17064)

Add permission field to StreamInput and merge it with agent permissions
when computing disabled tools. Forward session.permission from prompt.ts.

Upstream: anomalyco/opencode#17064 (c2ca149)

* fix(opencode): add prompt schema validation debug logs (backport B4 #17812)

Log info and part schema validation failures before persisting to help
diagnose data corruption issues.

Upstream: anomalyco/opencode#17812 (fee3c19)

---------

Co-authored-by: Kit Langton <kit.langton@gmail.com>
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Co-authored-by: Johannes Loher <johannes.loher@tngtech.com>
Co-authored-by: Adrian Mârza <adi11235 at gmail dot com>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Co-authored-by: DS <78942835+Tarquinen@users.noreply.github.com>
Co-authored-by: Jason Quense <monastic.panic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdk.prompt({ tools }) does not override agent configured permissions

2 participants