Create diff for generator for multipart/form-data

tsp-output/@azure-tools/typespec-csharp/src/Generated/Internal/ClientPipelineExtensions.cs

@@ -1,49 +1,37 @@
 // <auto-generated/>
 
-#nullable disable
+#nullable enable
 
-using System;
 using System.ClientModel;
 using System.ClientModel.Primitives;
-using System.Threading;
 using System.Threading.Tasks;
 
 namespace OpenAI
 {
     internal static class ClientPipelineExtensions
     {
-        public static async ValueTask<PipelineResponse> ProcessMessageAsync(this ClientPipeline pipeline, PipelineMessage message, RequestOptions requestContext, CancellationToken cancellationToken = default)
+        public static async ValueTask<PipelineResponse> ProcessMessageAsync(this ClientPipeline pipeline, PipelineMessage message, RequestOptions options)
         {
             await pipeline.SendAsync(message).ConfigureAwait(false);
 
-            if (message.Response == null)
+            if (message.Response!.IsError && options.ErrorOptions == ClientErrorBehaviors.Default)
             {
-                throw new InvalidOperationException("Failed to receive Result.");
+                throw await ClientResultException.CreateAsync(message.Response).ConfigureAwait(false);
             }
 
-            if (!message.Response.IsError || requestContext?.ErrorOptions == ClientErrorBehaviors.NoThrow)
-            {
-                return message.Response;
-            }
-
-            throw new ClientResultException(message.Response);
+            return message.Response;
         }
 
-        public static PipelineResponse ProcessMessage(this ClientPipeline pipeline, PipelineMessage message, RequestOptions requestContext, CancellationToken cancellationToken = default)
+        public static PipelineResponse ProcessMessage(this ClientPipeline pipeline, PipelineMessage message, RequestOptions options)
         {
             pipeline.Send(message);
 
-            if (message.Response == null)
-            {
-                throw new InvalidOperationException("Failed to receive Result.");
-            }
-
-            if (!message.Response.IsError || requestContext?.ErrorOptions == ClientErrorBehaviors.NoThrow)
+            if (message.Response!.IsError && options.ErrorOptions == ClientErrorBehaviors.Default)
             {
-                return message.Response;
+                throw new ClientResultException(message.Response);
             }
 
-            throw new ClientResultException(message.Response);
+            return message.Response;
         }
 
         public static async ValueTask<ClientResult<bool>> ProcessHeadAsBoolMessageAsync(this ClientPipeline pipeline, PipelineMessage message, RequestOptions requestContext)

tsp-output/@azure-tools/typespec-csharp/src/Generated/Internal/ClientUriBuilder.cs

@@ -1,210 +1,82 @@
-// <auto-generated/>
+// <auto-generated/>
 
-#nullable disable
+#nullable enable
 
 using System;
-using System.Collections.Generic;
-using System.Linq;
 using System.Text;
 
-namespace OpenAI
-{
-    internal class ClientUriBuilder
-    {
-        private UriBuilder _uriBuilder;
-        private StringBuilder _pathBuilder;
-        private StringBuilder _queryBuilder;
-        private const char PathSeparator = '/';
-
-        public ClientUriBuilder()
-        {
-        }
-
-        private UriBuilder UriBuilder => _uriBuilder ??= new UriBuilder();
-
-        private StringBuilder PathBuilder => _pathBuilder ??= new StringBuilder(UriBuilder.Path);
-
-        private StringBuilder QueryBuilder => _queryBuilder ??= new StringBuilder(UriBuilder.Query);
-
-        public void Reset(Uri uri)
-        {
-            _uriBuilder = new UriBuilder(uri);
-            _pathBuilder = new StringBuilder(UriBuilder.Path);
-            _queryBuilder = new StringBuilder(UriBuilder.Query);
-        }
-
-        public void AppendPath(string value, bool escape)
-        {
-            Argument.AssertNotNullOrWhiteSpace(value, nameof(value));
-
-            if (escape)
-            {
-                value = Uri.EscapeDataString(value);
-            }
-
-            if (value[0] == PathSeparator)
-            {
-                value = value.Substring(1);
-            }
-
-            PathBuilder.Append(value);
-            UriBuilder.Path = PathBuilder.ToString();
-        }
-
-        public void AppendPath(bool value, bool escape = false)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
-
-        public void AppendPath(float value, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
-
-        public void AppendPath(double value, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
-
-        public void AppendPath(int value, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
-
-        public void AppendPath(byte[] value, string format, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value, format), escape);
-        }
-
-        public void AppendPath(IEnumerable<string> value, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
-
-        public void AppendPath(DateTimeOffset value, string format, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value, format), escape);
-        }
-
-        public void AppendPath(TimeSpan value, string format, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value, format), escape);
-        }
-
-        public void AppendPath(Guid value, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
+namespace OpenAI;
 
-        public void AppendPath(long value, bool escape = true)
-        {
-            AppendPath(ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
-
-        public void AppendQuery(string name, string value, bool escape)
-        {
-            Argument.AssertNotNullOrWhiteSpace(name, nameof(name));
-            Argument.AssertNotNullOrWhiteSpace(value, nameof(value));
-
-            if (QueryBuilder.Length == 0)
-            {
-                QueryBuilder.Append('?');
-            }
-            else
-            {
-                QueryBuilder.Append('&');
-            }
-
-            if (escape)
-            {
-                value = Uri.EscapeDataString(value);
-            }
-
-            QueryBuilder.Append(name);
-            QueryBuilder.Append('=');
-            QueryBuilder.Append(value);
-        }
+internal class ClientUriBuilder
+{
+    private UriBuilder? _uriBuilder;
+    private StringBuilder? _pathBuilder;
+    private StringBuilder? _queryBuilder;
 
-        public void AppendQuery(string name, bool value, bool escape = false)
-        {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
+    private UriBuilder UriBuilder => _uriBuilder ??= new();
+    private StringBuilder PathBuilder => _pathBuilder ??= new(UriBuilder.Path);
+    private StringBuilder QueryBuilder => _queryBuilder ??= new(UriBuilder.Query);
 
-        public void AppendQuery(string name, float value, bool escape = true)
-        {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
+    public ClientUriBuilder()
+    {
+    }
 
-        public void AppendQuery(string name, DateTimeOffset value, string format, bool escape = true)
-        {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value, format), escape);
-        }
+    public void Reset(Uri uri)
+    {
+        _uriBuilder = new(uri);
+        _pathBuilder = new(_uriBuilder.Path);
+        _queryBuilder = new(_uriBuilder.Query);
+    }
 
-        public void AppendQuery(string name, TimeSpan value, string format, bool escape = true)
-        {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value, format), escape);
-        }
+    public void AppendPath(string value, bool escape)
+    {
+        Argument.AssertNotNullOrWhiteSpace(value, nameof(value));
 
-        public void AppendQuery(string name, double value, bool escape = true)
+        if (escape)
         {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
+            value = Uri.EscapeDataString(value);
         }
 
-        public void AppendQuery(string name, decimal value, bool escape = true)
-        {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
+        PathBuilder.Append(value);
+        UriBuilder.Path = PathBuilder.ToString();
+    }
 
-        public void AppendQuery(string name, int value, bool escape = true)
-        {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
+    public void AppendQuery(string name, string value, bool escape)
+    {
+        Argument.AssertNotNullOrWhiteSpace(name, nameof(name));
+        Argument.AssertNotNullOrWhiteSpace(value, nameof(value));
 
-        public void AppendQuery(string name, long value, bool escape = true)
+        if (QueryBuilder.Length is 0)
         {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
+            QueryBuilder.Append('?');
         }
-
-        public void AppendQuery(string name, TimeSpan value, bool escape = true)
+        else
         {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
+            QueryBuilder.Append('&');
         }
 
-        public void AppendQuery(string name, byte[] value, string format, bool escape = true)
+        if (escape)
         {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value, format), escape);
+            value = Uri.EscapeDataString(value);
         }
 
-        public void AppendQuery(string name, Guid value, bool escape = true)
-        {
-            AppendQuery(name, ModelSerializationExtensions.TypeFormatters.ConvertToString(value), escape);
-        }
+        QueryBuilder.Append(name);
+        QueryBuilder.Append('=');
+        QueryBuilder.Append(value);
+    }
 
-        public void AppendQueryDelimited<T>(string name, IEnumerable<T> value, string delimiter, bool escape = true)
+    public Uri ToUri()
+    {
+        if (_pathBuilder is not null)
         {
-            var stringValues = value.Select(v => ModelSerializationExtensions.TypeFormatters.ConvertToString(v));
-            AppendQuery(name, string.Join(delimiter, stringValues), escape);
+            UriBuilder.Path = _pathBuilder.ToString();
         }
 
-        public void AppendQueryDelimited<T>(string name, IEnumerable<T> value, string delimiter, string format, bool escape = true)
+        if (_queryBuilder is not null)
         {
-            var stringValues = value.Select(v => ModelSerializationExtensions.TypeFormatters.ConvertToString(v, format));
-            AppendQuery(name, string.Join(delimiter, stringValues), escape);
+            UriBuilder.Query = _queryBuilder.ToString();
         }
 
-        public Uri ToUri()
-        {
-            if (_pathBuilder != null)
-            {
-                UriBuilder.Path = _pathBuilder.ToString();
-            }
-
-            if (_queryBuilder != null)
-            {
-                UriBuilder.Query = _queryBuilder.ToString();
-            }
-
-            return UriBuilder.Uri;
-        }
+        return UriBuilder.Uri;
     }
-}
+}

tsp-output/@azure-tools/typespec-csharp/src/Generated/Internal/ModelSerializationExtensions.cs

@@ -257,7 +257,7 @@ internal static class TypeFormatters
             public static string ToString(DateTime value, string format) => value.Kind switch
             {
                 DateTimeKind.Utc => ToString((DateTimeOffset)value, format),
-                _ => throw new NotSupportedException($"DateTime {value} has a Kind of {value.Kind}. Azure SDK requires it to be UTC. You can call DateTime.SpecifyKind to change Kind property value to DateTimeKind.Utc.")
+                _ => throw new NotSupportedException($"DateTime {value} has a Kind of {value.Kind}. Generated clients require it to be UTC. You can call DateTime.SpecifyKind to change Kind property value to DateTimeKind.Utc.")
             };
 
             public static string ToString(DateTimeOffset value, string format) => format switch

tsp-output/@azure-tools/typespec-csharp/src/Generated/Models/AudioSegment.Serialization.cs

@@ -205,15 +205,15 @@ AudioSegment IPersistableModel<AudioSegment>.Create(BinaryData data, ModelReader
         string IPersistableModel<AudioSegment>.GetFormatFromOptions(ModelReaderWriterOptions options) => "J";
 
         /// <summary> Deserializes the model from a raw response. </summary>
-        /// <param name="response"> The result to deserialize the model from. </param>
+        /// <param name="response"> The response to deserialize the model from. </param>
         internal static AudioSegment FromResponse(PipelineResponse response)
         {
             using var document = JsonDocument.Parse(response.Content);
             return DeserializeAudioSegment(document.RootElement);
         }
 
-        /// <summary> Convert into a Utf8JsonRequestBody. </summary>
-        internal virtual BinaryContent ToBinaryBody()
+        /// <summary> Convert into a BinaryContent. </summary>
+        internal virtual BinaryContent ToBinaryContent()
         {
             return BinaryContent.Create(this, new ModelReaderWriterOptions("W"));
         }

tsp-output/@azure-tools/typespec-csharp/src/Generated/Models/CreateSpeechRequest.Serialization.cs

@@ -164,15 +164,15 @@ CreateSpeechRequest IPersistableModel<CreateSpeechRequest>.Create(BinaryData dat
         string IPersistableModel<CreateSpeechRequest>.GetFormatFromOptions(ModelReaderWriterOptions options) => "J";
 
         /// <summary> Deserializes the model from a raw response. </summary>
-        /// <param name="response"> The result to deserialize the model from. </param>
+        /// <param name="response"> The response to deserialize the model from. </param>
         internal static CreateSpeechRequest FromResponse(PipelineResponse response)
         {
             using var document = JsonDocument.Parse(response.Content);
             return DeserializeCreateSpeechRequest(document.RootElement);
         }
 
-        /// <summary> Convert into a Utf8JsonRequestBody. </summary>
-        internal virtual BinaryContent ToBinaryBody()
+        /// <summary> Convert into a BinaryContent. </summary>
+        internal virtual BinaryContent ToBinaryContent()
         {
             return BinaryContent.Create(this, new ModelReaderWriterOptions("W"));
         }