resolves SCM changes ClientUriBuilder#4519
Merged
ArcturusZhang merged 19 commits intoAzure:feature/v3from Apr 22, 2024
Merged
Conversation
ArcturusZhang
commented
Apr 11, 2024
lirenhe
approved these changes
Apr 15, 2024
annelo-msft
reviewed
Apr 15, 2024
annelo-msft
reviewed
Apr 15, 2024
ArcturusZhang
commented
Apr 17, 2024
annelo-msft
reviewed
Apr 19, 2024
annelo-msft
reviewed
Apr 19, 2024
annelo-msft
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4567
Description
We have this
ifstatement inClientUriBuilderto avoid duplicated separators:but in some cases it removes the separator incorrectly when there is no duplicate (as described in the above issue).
This PR refines the check to ensure neither of these happens
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?