Skip to content

Commit

Permalink
Remove init_default function (CrayLabs#545)
Browse files Browse the repository at this point in the history
This PR removes the helper function `init_default` and instead
implements traditional type narrowing.

[ reviewed by @MattToast ]
[ committed by @amandarichardsonn ]
  • Loading branch information
amandarichardsonn authored and ankona committed May 7, 2024
1 parent ec47854 commit d9f638b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ To be released at some future point in time
Description

- Fix race condition for telemetry monitor
- Remove helper function ``init_default``
- Fix telemetry monitor logging errrors for task history
- Change default path for entities
- Drop Python 3.8 support
Expand All @@ -44,6 +45,8 @@ Description
Detailed Notes

- Ensure the telemetry monitor is started prior to launching entities (SmartSim-PR549_)
- Remove helper function ``init_default`` and replace with traditional type
narrowing. (SmartSim-PR545_)
- Ensure the telemetry monitor does not track a task_id
for a managed task. (SmartSim-PR557_)
- The default path for an entity is now the path to the experiment / the
Expand Down Expand Up @@ -110,6 +113,7 @@ Detailed Notes
the previously registered signal handler. (SmartSim-PR535_)

.. _SmartSim-PR549: https://github.com/CrayLabs/SmartSim/pull/549
.. _SmartSim-PR545: https://github.com/CrayLabs/SmartSim/pull/545
.. _SmartSim-PR557: https://github.com/CrayLabs/SmartSim/pull/557
.. _SmartSim-PR533: https://github.com/CrayLabs/SmartSim/pull/533
.. _SmartSim-PR544: https://github.com/CrayLabs/SmartSim/pull/544
Expand Down

0 comments on commit d9f638b

Please sign in to comment.