Remove init_default function #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #545 +/- ##
===========================================
- Coverage 71.12% 69.74% -1.39%
===========================================
Files 65 65
Lines 4544 4571 +27
===========================================
- Hits 3232 3188 -44
- Misses 1312 1383 +71
|
MattToast
approved these changes
Apr 18, 2024
smartsim/entity/dbobject.py
Outdated
Comment on lines
78
to
79
| inputs = inputs or [] | ||
| outputs = outputs or [] |
There was a problem hiding this comment.
Are these to lines needed? They look redundant to line 84.
amandarichardsonn
added
bug: minor
ankona
pushed a commit
to ankona/SmartSim
that referenced
this pull request
May 6, 2024
This PR removes the helper function `init_default` and instead implements traditional type narrowing. [ reviewed by @MattToast ] [ committed by @amandarichardsonn ]
ankona
pushed a commit
to ankona/SmartSim
that referenced
this pull request
May 7, 2024
This PR removes the helper function `init_default` and instead implements traditional type narrowing. [ reviewed by @MattToast ] [ committed by @amandarichardsonn ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the helper function
init_defaultand instead implements traditional type narrowing.