fix(chromedriver): use chromedriver patch version as semver pre-release version #498

andrevechina · 2021-06-16T09:58:42Z

Issue:
While trying to download Chromedriver version 91.0.4472.101, version 91.0.4472.19 is being downloaded instead, because:

Chromedriver patch version is not being considerer
Chromedriver version 91.0.4472.101 is listed before version 91.0.4472.19

Proposed solution:
Update getValidSemver so it generates semver versions that include all 4 Chromedriver version numbers:
<MAJOR>.<MINOR>.<BUILD>.<PATCH>

Chromedriver semver versions will always use the pre-release format:
<MAJOR>.<MINOR>.<BUILD>-patch.<PATCH>

Version precedence will include all 4 number as per:
Semantic Versioning 2.0.0 definition, section 11, sub-section 4
https://semver.org/#spec-item-11

Fixes:
#413
#496
#497

…se version

googlebot · 2021-06-16T09:58:59Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-16T09:58:59Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

andrevechina · 2021-06-16T10:34:33Z

@googlebot I signed it!

googlebot · 2021-06-16T10:34:41Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-16T10:34:41Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tbruna · 2021-06-16T10:39:27Z

@googlebot I fixed it.

google-cla · 2021-06-16T10:39:34Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2021-06-16T10:39:34Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tbruna · 2021-06-16T10:40:12Z

@googlebot I consent.

google-cla · 2021-06-16T10:40:19Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2021-06-16T10:40:19Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

andrevechina · 2021-06-16T10:57:44Z

spec/cmds/status_spec.ts

@@ -33,7 +33,7 @@ describe('status', () => {
        .catch(err => {
          done.fail();
        });
-  });
+  }, 30000);


Running update twice sometimes was taking more than Jasmine's default timeout (5s).
Updating this timeout to 30s made this test suite a lot more stable.

andrevechina · 2021-06-16T11:00:51Z

lib/cmds/status.ts

@@ -95,7 +95,7 @@ function status(options: Options) {
      if (semver.gt(a, b)) {
        return 1;
      } else {
-        return 0;
+        return -1;


Small fix on displaying versions sorted.

StanislavKharchenko · 2021-06-22T09:10:31Z

Hope someone can approve and merge this.
@cnishina as webdriver-manager maintainer?

kallebjork · 2021-07-06T13:30:14Z

For what it is worth. I applied this patch in one of our projects and it works great.

BEFORE THIS PATCH

node_modules/protractor/node_modules/webdriver-manager/bin/webdriver-manager update --versions.chrome=91.0.4472.101
-->
I/downloader - curl -o/Users/user/ws/app-x-workspace/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_91.0.4472.101.zip https://chromedriver.storage.googleapis.com/91.0.4472.19/chromedriver_mac64.zip

AFTER THIS PATCH

node_modules/protractor/node_modules/webdriver-manager/bin/webdriver-manager update --versions.chrome=91.0.4472.101
-->
I/downloader - curl -o/Users/user/ws/app-x-workspace/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_91.0.4472.101.zip https://chromedriver.storage.googleapis.com/91.0.4472.101/chromedriver_mac64.zip

StanislavKharchenko · 2021-07-09T09:46:04Z

@angular @kyliau @Splaktar could someone from Angular team approve and merge this PR?
I forgot that Craig @cnishina no longer maintain this package.
Will be better to merge also with both webdriver-manager 12.x and 13.x

krissteinort · 2021-07-16T19:26:15Z

Just want to bump this one since it's been open for a month, any chance someone from the Angular team can merge this please? 🙏 @angular @kyliau @Splaktar?

kvbutler · 2021-07-19T17:01:29Z

Yup bump, someone please merge this PR.

kvbutler · 2021-07-19T21:14:20Z

Actually there is an issue with this, see my PR, https://github.com/andrevechina/webdriver-manager/pull/1.

For those who want a quick fix I published a new npm package.

Ugly workaround below.

package.json postinstall script:

"postinstall": "cd ./node_modules/protractor && npm i webdriver-manager@npm:webdriver-manager-hf-patchversion"

Also for context I have another script in package.json:

"update-webdriver": "webdriver-manager update --versions.chrome"

And I run it as such:

npm run update-webdriver -- 91.0.4472.124

You should see the correct version of the chromedriver after this.

kvbutler · 2021-07-21T13:27:20Z

Does anyone maintain this codebase anymore @angular @kyliau @Splaktar @cnishina?

dgp1130 · 2021-09-23T01:25:43Z

Heya, apologies about the delayed response here. The Angular team has been preoccupied with other challenges lately and haven't been able to give Protractor and webdriver-manager the attention they deserve.

The PR here seems like a solid fix to a pretty clear bug and I don't have any concerns with merging it. Unfortunately, the repository is in a bit of an awkward state right now, as some CI actions aren't running and 7.x.x isn't even on the master branch right now. I'm hoping to spend some time fixing this up and getting the repository back into a releaseable state, and once that happens we should be able to merge this and get a release out.

André Vechina added 2 commits June 15, 2021 16:12

fix(chromedriver): use chromedriver patch version as semver pre-relea…

e46e205

…se version

fix(chromedriver): fix unstable unit tests on cli status command

f2fc60e

googlebot added the cla: no label Jun 16, 2021

fix(chromedriver): add unit test

04657bb

google-cla bot added cla: yes and removed cla: no labels Jun 16, 2021

andrevechina commented Jun 16, 2021

View reviewed changes

sadym-chromium mentioned this pull request Jun 22, 2021

Chromedriver v91 regression: applying .getAttribute('value') on elements with tag name 'input' returns null instead of actual value #497

Open

andrevechina closed this by deleting the head repository Jan 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(chromedriver): use chromedriver patch version as semver pre-release version #498

fix(chromedriver): use chromedriver patch version as semver pre-release version #498

andrevechina commented Jun 16, 2021 •

edited

Loading

googlebot commented Jun 16, 2021

google-cla bot commented Jun 16, 2021

andrevechina commented Jun 16, 2021

googlebot commented Jun 16, 2021

google-cla bot commented Jun 16, 2021

tbruna commented Jun 16, 2021

google-cla bot commented Jun 16, 2021

googlebot commented Jun 16, 2021

tbruna commented Jun 16, 2021

google-cla bot commented Jun 16, 2021

googlebot commented Jun 16, 2021

andrevechina Jun 16, 2021

andrevechina Jun 16, 2021 •

edited

Loading

StanislavKharchenko commented Jun 22, 2021

kallebjork commented Jul 6, 2021 •

edited

Loading

StanislavKharchenko commented Jul 9, 2021

krissteinort commented Jul 16, 2021 •

edited

Loading

kvbutler commented Jul 19, 2021

kvbutler commented Jul 19, 2021 •

edited

Loading

kvbutler commented Jul 21, 2021

dgp1130 commented Sep 23, 2021

fix(chromedriver): use chromedriver patch version as semver pre-release version #498

fix(chromedriver): use chromedriver patch version as semver pre-release version #498

Conversation

andrevechina commented Jun 16, 2021 • edited Loading

googlebot commented Jun 16, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Jun 16, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

andrevechina commented Jun 16, 2021

googlebot commented Jun 16, 2021

google-cla bot commented Jun 16, 2021

tbruna commented Jun 16, 2021

google-cla bot commented Jun 16, 2021

googlebot commented Jun 16, 2021

tbruna commented Jun 16, 2021

google-cla bot commented Jun 16, 2021

googlebot commented Jun 16, 2021

andrevechina Jun 16, 2021

Choose a reason for hiding this comment

andrevechina Jun 16, 2021 • edited Loading

Choose a reason for hiding this comment

StanislavKharchenko commented Jun 22, 2021

kallebjork commented Jul 6, 2021 • edited Loading

BEFORE THIS PATCH

AFTER THIS PATCH

StanislavKharchenko commented Jul 9, 2021

krissteinort commented Jul 16, 2021 • edited Loading

kvbutler commented Jul 19, 2021

kvbutler commented Jul 19, 2021 • edited Loading

kvbutler commented Jul 21, 2021

dgp1130 commented Sep 23, 2021

andrevechina commented Jun 16, 2021 •

edited

Loading

andrevechina Jun 16, 2021 •

edited

Loading

kallebjork commented Jul 6, 2021 •

edited

Loading

krissteinort commented Jul 16, 2021 •

edited

Loading

kvbutler commented Jul 19, 2021 •

edited

Loading