-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chromedriver): don't ignore patch version #413
base: legacy
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@TravkinAlex @cnishina @heathkit @alexeagle Hello, could anyone please merge this pull request and release a new version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs more work but thank you for looking into this.
lib/binaries/chrome_xml.ts
Outdated
const exec = newRegex.exec(version); | ||
if (exec) { | ||
lookUpVersion = exec[1]; | ||
lookUpVersion = exec[1] + exec[2]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start but probably won't do it. I can see where we might have 74.0.5.5 and then we'll get 74.1.4.4. We will just grab 74.0.5.5 with your change. Possibly we could make two semver objs from chromedriver <a.b.c.d> we could have one that is a.b.c and another one that is b.c.d. We could check what is the a.b.c versions and then compare the b.c.d versions for the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@cnishina could you please take a look again? I really did my best, but I'm not knowledgeable on development of such things and basically was just clutching at straws trying to fix this 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
@cnishina don't want to be nagging because I don't really know the due process of contributing to this repository (and open-source in general), but could you please review this once more? |
Does this fix the issue where latest would grab x.12 before x.126 as it was higher in the list of releases? My #418 PR uses some of the v13 code of webdriver-manager to find latest from the LATEST_RELEASE_7X url then grabs that specific binary. |
@Lampei yes, it does, getting the latest one (e.g. without providing specific --version for chrome) grabs the 76.0.3809.126 version, we've actually started using custom webdriver-manager with this fix on our project and everything works as intended (it's published to our own Artifactory). |
I think it's just that v13 uses maxVersion of 77 for chrome but 12 is using 76 (which is what I need for my testing). I had been tweaking my PR a little today, but trying to figure out some of the logic in the chrome_xml was causing me grief. I found that if we update our |
@cnishina I've synced to the latest legacy branch, could you please take a look? We use getting of specific version everywhere on our project, this is highly desirable fix. |
Fixes #408Fixes #424
Before fix:
After fix: