feat(frameworks/cli): add ability for jasmine to produce json result out... #1449
Conversation
hankduan
force-pushed
the
jsonOutputOption
branch
from
39d4785 to
b487364
Compare
hankduan
force-pushed
the
jsonOutputOption
branch
from
b487364 to
a2f61d9
Compare
| @@ -66,10 +59,54 @@ exports.run = function(runner, specs) { | |||
| }; | |||
|
|
|||
| deferred.resolve(resolvedObj); | |||
| }catch(err){ | |||
| } catch(err){ | |||
There was a problem hiding this comment.
Thanks for fixing - can you add a space after the ) as well?
|
Hm, I feel like instead of doing this manually for Jasmine and Mocha, we should extend the runner events to emit some data about the test with the 'testPass' / 'testFail' events, and then be able to attach a reporter from the launcher. |
|
Ok, in that case, it's going to involve a relatively big launcher refactor. But I think this refactor would be good as it makes the code for multi/single runner more similar, and removes duplication in this PR. I'll work on that and send another PR |
|
Closing as completely replaced by #1485 |
...put