This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
feat(scripts): add framework to test protractor #1450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankduan
force-pushed
the
testingProtractor
branch
from
7372611 to
2c588ec
Compare
hankduan
force-pushed
the
testingProtractor
branch
2 times, most recently
from
a65b2f3 to
a9e7c51
Compare
hankduan
force-pushed
the
testingProtractor
branch
from
a9e7c51 to
6ac5867
Compare
|
fixed this PR to work with #1485. |
|
|
||
| var scripts = [ | ||
| var passing_tests = [ |
|
Left a bunch of small comments, but I think overall this is good. |
|
I think I accidentally change the hash id, so it's recreating a separate PR instead of doing it on top of this one. Closing this, and continuing here: #1505 (all comments addressed) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.