Skip to content

Commit

Permalink
build: avoid use of github team for dev-infra codeowner (#25337)
Browse files Browse the repository at this point in the history
We should just use the explicit names since there aren't a lot
of instances, and this is not changing very often.

The change back then did not bring a lot of benefits but rather made
reviews more annoying since unrelevant PRs had to be unassigned twice
to disappear in the `Requested reviews` view. This is because I'm
sometimes requested explicitly through other ownerships, but then also
through the dev-infra group.
  • Loading branch information
devversion committed Jul 25, 2022
1 parent e045e8d commit 3fc9d16
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,11 @@
/integration/** @andrewseguin @devversion

# Tooling
/.circleci/** @angular/dev-infra-components
/.yarn/** @angular/dev-infra-components
/scripts/** @angular/dev-infra-components
/test/** @angular/dev-infra-components
/tools/** @angular/dev-infra-components
/.circleci/** @devversion @josephperrott
/.yarn/** @devversion @josephperrott
/scripts/** @devversion @josephperrott
/test/** @devversion @josephperrott
/tools/** @devversion @josephperrott

# Public API golden files
/tools/public_api_guard/cdk/a11y** @jelbourn @devversion
Expand Down Expand Up @@ -345,13 +345,13 @@
/tools/public_api_guard/youtube-player/** @andrewseguin

# Misc
/.github/** @angular/dev-infra-components
/.husky/** @angular/dev-infra-components
/.github/CODEOWNERS @angular/dev-infra-components @andrewseguin @jelbourn
/.github/** @devversion @josephperrott
/.husky/** @devversion @josephperrott
/.github/CODEOWNERS @devversion @josephperrott @andrewseguin @jelbourn
/.github/ISSUE_TEMPLATE/** @andrewseguin @jelbourn
/.vscode/** @angular/dev-infra-components @mmalerba
/.ng-dev/** @angular/dev-infra-components
/.vscode/** @devversion @josephperrott @mmalerba
/.ng-dev/** @devversion @josephperrott
/goldens/size-test.yml @andrewseguin @mmalerba @crisbeto
/goldens/** @angular/dev-infra-components
/src/* @angular/dev-infra-components
/* @angular/dev-infra-components
/goldens/** @devversion @josephperrott
/src/* @devversion @josephperrott
/* @devversion @josephperrott

0 comments on commit 3fc9d16

Please sign in to comment.