build: avoid use of github team for dev-infra codeowner #25337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should just use the explicit names since there aren't a lot of instances, and this is not changing very often. The change back then did not bring a lot of benefits but rather made reviews more annoying since unrelevant PRs had to be unassigned twice to disappear in the `Requested reviews` view. This is because I'm sometimes requested explicitly through other ownerships, but then also through the dev-infra group.
devversion
requested review from
a team,
andrewseguin and
jelbourn
as code owners
devversion
added
action: merge
devversion
added a commit
that referenced
this pull request
Jul 25, 2022
We should just use the explicit names since there aren't a lot of instances, and this is not changing very often. The change back then did not bring a lot of benefits but rather made reviews more annoying since unrelevant PRs had to be unassigned twice to disappear in the `Requested reviews` view. This is because I'm sometimes requested explicitly through other ownerships, but then also through the dev-infra group.
devversion
added a commit
that referenced
this pull request
Jul 25, 2022
We should just use the explicit names since there aren't a lot of instances, and this is not changing very often. The change back then did not bring a lot of benefits but rather made reviews more annoying since unrelevant PRs had to be unassigned twice to disappear in the `Requested reviews` view. This is because I'm sometimes requested explicitly through other ownerships, but then also through the dev-infra group.
devversion
added
target: patch
This was referenced Aug 9, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should just use the explicit names since there aren't a lot
of instances, and this is not changing very often.
The change back then did not bring a lot of benefits but rather made
reviews more annoying since irrelevant PRs had to be unassigned twice
to disappear in the
Requested reviewsview. This is because I'msometimes requested explicitly through other ownerships, but then also
through the dev-infra group.
Also changed the owners of
goldens/away from dev-infra since I don't know thatthis is correct. Codeowners are not super strictly needed in this repo anyway..