Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Grid.js) Vertical scroll calculates height wrong with enableHorizontalScrollbar: NEVER #6690

Merged
merged 4 commits into from
Apr 23, 2018
Merged

fix(Grid.js) Vertical scroll calculates height wrong with enableHorizontalScrollbar: NEVER #6690

merged 4 commits into from
Apr 23, 2018

Commits on Apr 12, 2018

  1. fix(Grid.js): ScrollIfNecessary does not account for scrollWidth corr… 

    …ectly

Since scrollIfNecessary is called multiple times when enableCellEditOnFocus is true we need to make sure the scrollbarWidth and footerHeight is accounted for to not cause a loop.

fixes angular-ui#6653
    @macomage
    macomage committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    2ec1e70 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2018

  1. Add check for gridCol not null 

    Make sure gridCol is not null before checking for enableCellEditOnFocus
    @macomage
    macomage committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    8dab50a View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Merge https://github.com/angular-ui/ui-grid

    @macomage
    macomage committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    e67c1e1 View commit details
    Browse the repository at this point in the history

  2. fix(Grid.js) Vertical scroll calculates height wrong with enableHoriz… 

    …ontalScrollbar: NEVER

Use scrollbarHeight instead of scrollbarWidth for vertical scroll calculations. scrollbarHeight has the value 0 when enableHorizontalScrollbar is set to NEVER.

Round calculated boundary values as computed style may have decimal number which will not match pixelsToSeeRow
    @macomage
    macomage committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    e485993 View commit details
    Browse the repository at this point in the history