fix(Grid.js) Vertical scroll calculates height wrong with enableHorizontalScrollbar: NEVER #6690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectly Since scrollIfNecessary is called multiple times when enableCellEditOnFocus is true we need to make sure the scrollbarWidth and footerHeight is accounted for to not cause a loop. fixes angular-ui#6653
Make sure gridCol is not null before checking for enableCellEditOnFocus
…ontalScrollbar: NEVER Use scrollbarHeight instead of scrollbarWidth for vertical scroll calculations. scrollbarHeight has the value 0 when enableHorizontalScrollbar is set to NEVER. Round calculated boundary values as computed style may have decimal number which will not match pixelsToSeeRow
|
Found two more scenarios where a loop could occur, seem to be specifically firefox. |
defields923
pushed a commit
to defields923/ui-grid
that referenced
this pull request
Oct 30, 2018
…ontalScrollbar: NEVER (angular-ui#6690) * fix(Grid.js): ScrollIfNecessary does not account for scrollWidth correctly Since scrollIfNecessary is called multiple times when enableCellEditOnFocus is true we need to make sure the scrollbarWidth and footerHeight is accounted for to not cause a loop. fixes angular-ui#6653 * Add check for gridCol not null Make sure gridCol is not null before checking for enableCellEditOnFocus * fix(Grid.js) Vertical scroll calculates height wrong with enableHorizontalScrollbar: NEVER Use scrollbarHeight instead of scrollbarWidth for vertical scroll calculations. scrollbarHeight has the value 0 when enableHorizontalScrollbar is set to NEVER. Round calculated boundary values as computed style may have decimal number which will not match pixelsToSeeRow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use scrollbarHeight instead of scrollbarWidth for vertical scroll calculations. scrollbarHeight has the value 0 when enableHorizontalScrollbar is set to NEVER.
Round calculated boundary values as computed style may have decimal number which will not match pixelsToSeeRow
Related to: #6653