Skip to content

chore: enable TreatWarningsAsErrors and fix existing warnings #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andregoepel merged 1 commit into from
Jul 26, 2026
Merged

chore: enable TreatWarningsAsErrors and fix existing warnings #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,10 @@
<!-- Generate and honour packages.lock.json so restores are reproducible and
tamper-evident; CI restores in locked mode to fail on any drift (#36). -->
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!-- Low/moderate NuGet audit findings stay visible as warnings instead of
breaking every build when a new CVE is published; NU1903/NU1904
(high/critical) remain errors. -->
<WarningsNotAsErrors>NU1901;NU1902</WarningsNotAsErrors>
</PropertyGroup>
</Project>
5 changes: 5 additions & 0 deletions samples/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,10 @@
<IsPackable>false</IsPackable>
<!-- Samples are apps, not packages, and don't need the repo's reproducible-restore gating. -->
<RestorePackagesWithLockFile>false</RestorePackagesWithLockFile>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!-- Low/moderate NuGet audit findings stay visible as warnings instead of
breaking every build when a new CVE is published; NU1903/NU1904
(high/critical) remain errors. -->
<WarningsNotAsErrors>NU1901;NU1902</WarningsNotAsErrors>
</PropertyGroup>
</Project>
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/ConfirmEmail.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ private static UserManager<User> BuildUserManager()
var store = Substitute.For<IUserStore<User>>();
return Substitute.For<UserManager<User>>(
store,
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
}

Expand Down
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/ConfirmEmailChange.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ private static UserManager<User> BuildUserManager()
var store = Substitute.For<IUserStore<User>>();
return Substitute.For<UserManager<User>>(
store,
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
}

Expand Down
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/Login.Localization.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ private IRenderedComponent<Login> Render()

var um = Substitute.For<UserManager<User>>(
Substitute.For<IUserStore<User>>(),
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
var sm = Substitute.For<SignInManager<User>>(
um,
Expand Down
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/Login.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ private IRenderedComponent<Login> Render(IdentityFeatureFlags flags)

var um = Substitute.For<UserManager<User>>(
Substitute.For<IUserStore<User>>(),
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
var sm = Substitute.For<SignInManager<User>>(
um,
Expand Down
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/LoginForm.Localization.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,14 @@ Action<UserManager<User>, SignInManager<User>> configure
JSInterop.Mode = JSRuntimeMode.Loose;
var um = Substitute.For<UserManager<User>>(
Substitute.For<IUserStore<User>>(),
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
var sm = Substitute.For<SignInManager<User>>(
um,
Expand Down
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/LoginForm.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ public class LoginFormTests : BunitContext
private static UserManager<User> BuildUserManager() =>
Substitute.For<UserManager<User>>(
Substitute.For<IUserStore<User>>(),
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);

private static SignInManager<User> BuildSignInManager(UserManager<User> userManager) =>
Expand Down
16 changes: 8 additions & 8 deletions ...epel.Marten.Identity.Blazor.Tests/Account/Pages/Manage/ChangePassword.Validation.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ public async Task ChangePassword_ValidInput_ShowsNoValidationMessages()
// Arrange
var um = Substitute.For<UserManager<User>>(
Substitute.For<IUserStore<User>>(),
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
var cut = Render(um);

Expand Down
2 changes: 1 addition & 1 deletion ...reGoepel.Marten.Identity.Blazor.Tests/Account/Pages/Manage/Passkeys.Localization.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public async Task GermanCulture_Delete_PassesTheLocalizedNameAndTitleToTheConfir
await dialog
.Received(1)
.Confirm(
Arg.Is<string>(m => m.Contains("Passkey **My iPhone**")),
Arg.Is<string>(m => m != null && m.Contains("Passkey **My iPhone**")),
"Passkey löschen",
Arg.Any<ConfirmOptions>()
);
Expand Down
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/RegisterConfirmation.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ private static UserManager<User> BuildUserManager()
var store = Substitute.For<IUserStore<User>>();
return Substitute.For<UserManager<User>>(
store,
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
}

Expand Down
16 changes: 8 additions & 8 deletions ...ndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/ResetPassword.Localization.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ private static UserManager<User> BuildUserManager()
var store = Substitute.For<IUserStore<User>>();
return Substitute.For<UserManager<User>>(
store,
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
}

Expand Down
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Blazor.Tests/Account/Pages/ResetPassword.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ private static UserManager<User> BuildUserManager()
var store = Substitute.For<IUserStore<User>>();
return Substitute.For<UserManager<User>>(
store,
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
}

Expand Down
12 changes: 10 additions & 2 deletions tests/AndreGoepel.Marten.Identity.E2ETests/Tests/InvitationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ public async Task Admin_InvitesUser_InviteeSetsPassword_AndIsSignedIn()

// The invitation link is captured from the outgoing mail (the sample's default
// sender routes invitations through the password-reset path).
var link = await Fixture.Email.WaitForLinkAsync(invitee, "Account/AcceptInvitation");
var link = await Fixture.Email.WaitForLinkAsync(
invitee,
"Account/AcceptInvitation",
ct: TestContext.Current.CancellationToken
);

// The invitee opens the link in their own fresh session, not the admin's.
await using var inviteeContext = await Fixture.NewContextAsync();
Expand Down Expand Up @@ -71,7 +75,11 @@ public async Task InvitationLink_CannotBeReplayed_AfterAcceptance()
await Page.ClickButtonAsync("Invite user");
await Page.FillFieldAsync("Email", invitee);
await Page.ClickButtonAsync("Send invitation");
var link = await Fixture.Email.WaitForLinkAsync(invitee, "Account/AcceptInvitation");
var link = await Fixture.Email.WaitForLinkAsync(
invitee,
"Account/AcceptInvitation",
ct: TestContext.Current.CancellationToken
);

await using (var firstContext = await Fixture.NewContextAsync())
{
Expand Down
16 changes: 8 additions & 8 deletions tests/AndreGoepel.Marten.Identity.Tests/Http/CookieLoginMiddleware.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ private static SignInManager<User> BuildSignInManager()
var store = Substitute.For<IUserStore<User>>();
var userManager = Substitute.For<UserManager<User>>(
store,
null,
null,
null,
null,
null,
null,
null,
null
null!,
null!,
null!,
null!,
null!,
null!,
null!,
null!
);
return Substitute.For<SignInManager<User>>(
userManager,
Expand Down