chore: enable TreatWarningsAsErrors and fix existing warnings - #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TreatWarningsAsErrors=trueplus aWarningsNotAsErrorsexception for low/moderate NuGet audit findings (NU1901/NU1902) in both the root andsamples/Directory.Build.props(the samples props doesn't import the root — it's applied independently). High/critical findings (NU1903/NU1904) stay errors.CS8625— test helpers building an NSubstitute proxy ofUserManager<User>/SignInManager<User>passed barenullfor unused non-nullable constructor parameters; followed the existingnull!convention already used inAuthenticatedUserContext.csrather than inventing a new pattern. 2xxUnit1051and 1xCS8602fixed the same way as the other repos in this rollout.Test plan
dotnet build --no-incremental(full solution incl. samples) — 0 Warning(s), 0 Error(s)dotnet test—AndreGoepel.Marten.Identity.Tests191/191,AndreGoepel.Marten.Identity.Blazor.Tests130/130 passedAndreGoepel.Marten.Identity.IntegrationTests— not run, Docker daemon wasn't available in the dev environment this was built in. Needs a local run with Docker up before merging.AndreGoepel.Marten.Identity.E2ETests— not run (own CI workflow), but compiles cleanly with 0 warnings as part of the full builddotnet list package --vulnerable --include-transitive— no findingsCloses #150