fix: use "contents" field and remove "fullText" license field #3857
Merged
fix: use "contents" field and remove "fullText" license field #3857
Conversation
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
wagoodman
added
the
changelog-ignore
wagoodman
changed the title
5 tasks
wagoodman
reviewed
May 5, 2025
wagoodman
approved these changes
May 5, 2025
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
spiffcs
changed the title
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we do a release of syft we want to make sure the license fields are not duplicated. This removes
fullTextwhich was added #3450. It routes the changes of #3450 throughcontentswhich was added previously here: #3366Note to Reviewers: We previously included a struct tag for the contents field that ignored it as part of our
LicenseSetidentification process. This tag has been removed. Given that licenses can now be some combination ofUNKNOWN->CONTENTSwhere the difference in licenses is the "content" of theircontentswe could not longer continue ignoring this field. The resulting license sets would only allow for a singleUNKNOWNlicense.I have added a test that illustrates this behavior.
Type of change
Checklist: