Propagate error in FileSourceProvider instead of warn log#3845
Merged
wagoodman merged 2 commits intoanchore:mainfrom May 5, 2025
Merged
Propagate error in FileSourceProvider instead of warn log#3845wagoodman merged 2 commits intoanchore:mainfrom
wagoodman merged 2 commits intoanchore:mainfrom
Conversation
Signed-off-by: Kudryavcev Nikolay <kydry.nikolau@gmail.com>
wagoodman
approved these changes
May 5, 2025
…ve-error Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a user, I want to see an error if there is something wrong with my archive. But now syft just leaves userInput to the catalogers, hoping that they can handle an invalid archive.
Type of change
Checklist: