Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check flexbox-gap #172

Merged

Conversation

ZhukDmitryOlegovich
Copy link

Hello,

I'm new to doing PR in open source, so if I'm doing something wrong, I'll be glad to receive feedback

I decided to add doiuse to my project and there are a couple of things that stop me from using it, so I’m going to make a series of PRs in which I propose corrections or improvements that will help me


  1. Added a test case that doesn’t work for me
  2. Corrected the flexbox-gap check function

@ZhukDmitryOlegovich
Copy link
Author

Currently the css below is not defined as flexbox-gap.

.test {display:flex;gap:1rem;}
.test {
     display: /* some-comment */ flex;
     gap: 1rem;
}

I added these tests and corrected the function - now they are detected.

@clshortfuse clshortfuse added this to the 6.0.3 milestone Sep 25, 2023
Copy link
Collaborator

@clshortfuse clshortfuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some minor requests, but the logic looks good. Thanks for the PR!

data/features/flexbox-gap.js Outdated Show resolved Hide resolved
data/features/flexbox-gap.js Outdated Show resolved Hide resolved
data/features/flexbox-gap.js Outdated Show resolved Hide resolved
data/features/flexbox-gap.js Outdated Show resolved Hide resolved
@clshortfuse clshortfuse self-assigned this Oct 4, 2023
@clshortfuse clshortfuse merged commit e06e7c6 into anandthakker:master Oct 4, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants