code review

anandthakker · Oct 4, 2023 · e06e7c6 · e06e7c6
1 parent 4bede0b
commit e06e7c6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/data/features/flexbox-gap.js b/data/features/flexbox-gap.js
@@ -8,21 +8,17 @@
  * @type {import('../features').Feature}
  */
 export default (rule) => {
-  if (!('some' in rule)) {
-    return false;
-  }
+  if (!('some' in rule)) return false;
 
-  let isFlexbox = false;
-  let isGap = false;
+  let hasFlexbox = false;
+  let hasGap = false;
 
   return rule.some((decl) => {
-    if (decl.type !== 'decl') {
-      return false;
-    }
+    if (decl.type !== 'decl') return false;
 
-    isFlexbox ||= decl.prop === 'display' && (decl.value === 'flex' || decl.value === 'inline-flex');
-    isGap ||= decl.prop === 'gap' || decl.prop.endsWith('-gap');
+    hasFlexbox ||= decl.prop === 'display' && (decl.value === 'flex' || decl.value === 'inline-flex');
+    hasGap ||= decl.prop === 'gap' || decl.prop === 'column-gap' || decl.prop === 'row-gap';
 
-    return isFlexbox && isGap;
+    return hasFlexbox && hasGap;
   });
 };
diff --git a/test/cases/features/flexbox-gap.css b/test/cases/features/flexbox-gap.css
@@ -9,7 +9,7 @@ See: https://caniuse.com/flexbox-gap
 
 /*
 expect:
-flexbox-gap: 4
+flexbox-gap: 5
 */
 
 .test {
@@ -29,6 +29,11 @@ flexbox-gap: 4
   row-gap: 1rem;
 }
 
+.test {
+  display: flex;
+  column-gap: 1rem;
+}
+
 /* should not trigger */
 .test {
   display: grid;