Display-observer: a hidden tab should still be displayable for playback #32478
Conversation
| // The document is still considered "displayed" or at least "displayable" | ||
| // when it's hidden (tab is switched). Only prerender/paused/inactive | ||
| // states require pause of resources. | ||
| visibilityState == VisibilityState.HIDDEN |
There was a problem hiding this comment.
This state is also used when a viewer swipes to the next doc. Shouldn't that be marked as not displayed?
There was a problem hiding this comment.
Not this one. I checked and in the viewer, the sequence of states is: "visible" -> "paused" -> "inactive".
There was a problem hiding this comment.
Yup, tested and this works correctly. Viewer swipe leads to INACTIVE, and tab change leads to HIDDEN.
Should PAUSED be included here? I think yes. And what about PRERENDER? I think that could be likely no, because someone might depend on it and accidentally leak privacy.
There was a problem hiding this comment.
I believe, yes, because PAUSE is explicitly made for this use-case. I think the way this happens is that PAUSED is issued immediately and INACTIVE some time later to avoid too many unlayouts while the new page is loaded.
| // The document is still considered "displayed" or at least "displayable" | ||
| // when it's hidden (tab is switched). Only prerender/paused/inactive | ||
| // states require pause of resources. | ||
| visibilityState == VisibilityState.HIDDEN |
There was a problem hiding this comment.
Yup, tested and this works correctly. Viewer swipe leads to INACTIVE, and tab change leads to HIDDEN.
Should PAUSED be included here? I think yes. And what about PRERENDER? I think that could be likely no, because someone might depend on it and accidentally leak privacy.
Partial for #31915.
Partial for #31540.
Closes #32487.
These rules come from the Resources class. Notice that only "paused" and "inactive" cause transitions to
pause().