Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌸 Cherry-pick request for #32487 into #32408 (Pending) #32521

Closed
dvoytenko opened this issue Feb 8, 2021 · 2 comments
Closed

🌸 Cherry-pick request for #32487 into #32408 (Pending) #32521

dvoytenko opened this issue Feb 8, 2021 · 2 comments

Comments

@dvoytenko
Copy link
Contributor

dvoytenko commented Feb 8, 2021

Cherry-pick request

Issue PR Beta / Experimental? Stable? LTS? Release issue
#32487 #32478 YES NO NO #32408
#32487 #32478 NO YES YES #32229

Why does this issue meet the cherry-pick criteria?

The pausing is caused more often when tabs are switched then needed. Fixes a bad UX and an expectation for playback.

List the steps to manually verify the changes in this cherry-pick

See #32487.

Mini-postmortem

TODO: This postmortem will be written after the cherry-pick deployment and before this issue is closed. Delete this TODO when the postmortem is ready.

Summary

<1-2 sentences summarizing the problem and root causes.>

Impact

  • <Which users were affected? Roughly how many?>
  • <How were users affected? E.g. partial or complete loss of functionality?>

Action Items

  • #<ISSUE_NUMBER>: <Add unit/integration/end-to-end test>
  • #<ISSUE_NUMBER>: <Add monitoring for edge case via error logging>
  • #<ISSUE_NUMBER>: <Refactor an easily misused API>

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers

@jridgewell jridgewell changed the title 🌸 Cherry-pick request for #32487 into #<RELEASE_ISSUE> (Pending) 🌸 Cherry-pick request for #32487 into #32408 (Pending) Feb 8, 2021
@dvoytenko
Copy link
Contributor Author

The CP is ready.

@jridgewell
Copy link
Contributor

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants