Fix <textarea> scrollHeight calculation #32292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
requested review from
caroqliu and
dvoytenko
and removed request for
nainar
caroqliu
reviewed
Jan 29, 2021
| // It makes the scrollHeight calculation off by ~1px. | ||
| // This is why we have a small error margin. | ||
| // TODO: Remove error margin when chrome bug is resolved (https://bugs.chromium.org/p/chromium/issues/detail?id=1171989). | ||
| const errorMargin = /google/i.test(win.navigator.vendor) ? 3 : 0; |
There was a problem hiding this comment.
Is win preferred to this.win_ here? And should we also be checking if the document is zoomed at all?
There was a problem hiding this comment.
- We don't have access to this.win and it isn't a property of the textarea element either (not an AMP Component). win is already calculated earlier in the function, so it is better than writing element.ownerDocument.defaultView again.
- tabs.getZoom() would returns a Promise and I think would do the trick. My fear is that zoom isn't the root cause and it is really related to device pixel ratio - zoom is just the easiest repro method. Due to not understanding the underlying Chrome bug well enough, I'd rather stay on the safe side! WDYT
There was a problem hiding this comment.
- Oops 😬 You're so right, thanks for clarifying.
- It should be fine to keep. I don't foresee anything harmful happening because in the case where the bug is not present, and we are "overeager" to resize, the error margin doesn't actually factor into the given height.
caroqliu
approved these changes
Jan 29, 2021
zaparent
pushed a commit
to zaparent/amphtml
that referenced
this pull request
Jan 29, 2021
* Fix for textarea scrollHeight calculation * only apply in Chrome
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Jan 29, 2021
* 'master' of github.com:ampproject/amphtml: (1020 commits) 🏗 Clean up CI config files (ampproject#32303) 🏗 Remove Browser Installation from CI tasks and use smaller instances when possible (ampproject#32310) Cleanup fie-resources experiment (ampproject#32226) 🏗 Fix bug in build target discovery logic (ampproject#32307) 📖 Update TOC on TESTING.md (ampproject#32304) 🏗 Reorganize browserify caching code (ampproject#32297) Fix <textarea> scrollHeight calculation (ampproject#32292) 📖 Update testing docs (ampproject#32298) Fix missing space and mention `https` (ampproject#32293) ✨ [Story auto-analytics] Added validation and tests (ampproject#32288) 🏗 Consolidate remaining CircleCI VM setup steps into separate scripts (ampproject#32290) 🏗 Cache Karma's babel transforms during CircleCI builds (ampproject#32295) Add validation rules for aspect-ratio support via SSR (ampproject#32262) bump up viewer-messaging version (ampproject#32286) 🖍🚀 Alternate `position: fixed/absolute` when docking/undocking (ampproject#32243) ✨ [Panning media] Transition siblings by ID (ampproject#32217) 📦 Update dependency watchify to v4 (ampproject#32284) 📦 Update dependency rollup to v2.38.1 (ampproject#32274) 🐛♻️ ADS: XHRs race condtion and responsivnes fix (ampproject#32271) Add support for gdpr_conseented_providers, useCCPA_USPAPI, and _fw_us_privacy (ampproject#32275) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32291 and
b/150231440Related: https://bugs.chromium.org/p/chromium/issues/detail?id=1171989