Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-insert AMP Preview button whenever editor toolbar changes #6900

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Re-insert AMP Preview button whenever editor toolbar changes #6900

merged 1 commit into from
Feb 28, 2022

Conversation

delawski
Copy link
Collaborator

@delawski delawski commented Feb 7, 2022

Summary

Fixes #6893

The AMP Preview button should be re-inserted into the block editor DOM tree whenever settings in the post editor header change. The following properties may indicate such a change in the toolbar layout:

  • viewable prop; it gets defined once the toolbar has been rendered
  • saveable prop; when it changes, the toolbar has been reshuffled heavily

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@delawski delawski added Bug Something isn't working Editor labels Feb 7, 2022
@delawski delawski added this to the v2.2.2 milestone Feb 7, 2022
@delawski delawski self-assigned this Feb 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Plugin builds for b44b5f4 are ready 🛎️!

dhaval-parekh
dhaval-parekh approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@dhaval-parekh dhaval-parekh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@westonruter westonruter merged commit ce84537 into develop Feb 28, 2022
@westonruter westonruter deleted the fix/6893-show-amp-preview-button-initially branch February 28, 2022 21:07
westonruter pushed a commit that referenced this pull request Feb 28, 2022
@delawski @westonruter
Re-insert AMP Preview button whenever editor toolbar changes (#6900)
ea705bc
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaval-parekh dhaval-parekh dhaval-parekh approved these changes

@westonruter westonruter Awaiting requested review from westonruter

Assignees

@delawski delawski

Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Editor
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.

AMP Preview button is not showing up in WP 5.6, 5.7, and 5.8 initially
3 participants
@delawski @dhaval-parekh @westonruter