Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP Preview button is not showing up in WP 5.6, 5.7, and 5.8 initially #6893

Closed
delawski opened this issue Feb 4, 2022 · 1 comment · Fixed by #6900
Closed

AMP Preview button is not showing up in WP 5.6, 5.7, and 5.8 initially #6893

delawski opened this issue Feb 4, 2022 · 1 comment · Fixed by #6900
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Editor
Milestone

Comments

@delawski
Copy link
Collaborator

delawski commented Feb 4, 2022

I've just noticed an issue: the preview button is not showing up in WP 5.6, 5.7, and 5.8 until the user makes a change and then saves a draft.

wp-5.6-amp-preview-only-appears-after-saving.mov

It seems the container is empty:

image

And also, when I load a post that is published I see the button show up for a moment and then disappear until I make a change and save the post:

momentary-dispay-of-preview-button-when-published.mov

It doesn't happen in either 5.9 or in 5.7 or 5.8 with the latest Gutenberg is active.

So I don't consider this a blocker for 2.2.1, but it should be fixed in 2.2.2.

Originally posted by @westonruter in #6881 (comment)

@delawski delawski added Bug Something isn't working Editor labels Feb 4, 2022
@delawski delawski added this to the v2.3 milestone Feb 4, 2022
@delawski delawski self-assigned this Feb 4, 2022
@westonruter westonruter modified the milestones: v2.3, v2.2.2 Feb 7, 2022
@fellyph fellyph self-assigned this Mar 10, 2022
@dhaval-parekh
Copy link
Collaborator

QA Pass

Test in WordPress 5.8 (Similar result found in WordPress versions 5.6 and 6.7)

Before

WP-5.8-Before.mov

After

WP-5.8-After.mov

Similar results ( As shown in after video ) were found in the latest version the WordPress (5.9.2) with the new changes (and even without new changes)

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes. Editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants