-
Notifications
You must be signed in to change notification settings - Fork 54
fix: fix web attribution identify and session start order #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
3509d9e
fix: fix web attribution identify and session start order
yuhao900914 cb448e4
build: update other sdk dependency
yuhao900914 ff7f12a
fix: make campaign tracking order before page view tracking
yuhao900914 0151368
fix: fix the event id not right for web attribution identify
yuhao900914 45aa354
test: test
yuhao900914 0222d83
fix: clean up
yuhao900914 2ec62f5
fix: clean up
yuhao900914 cb3db32
fix: remove default web attribution plugin installation
yuhao900914 5ba44b1
build: revert the dependency in node and react-native
yuhao900914 d18e26a
test: clean the example
yuhao900914 7d7645f
fix: remove no-non-null-assertion
yuhao900914 9f6cfc8
fix: fix session event not fired
yuhao900914 1260a18
fix: merge with main
yuhao900914 a241181
fix: refine structure and fix test coverage
yuhao900914 f5a470c
fix: fixes based on commend
yuhao900914 ca2214d
test: fix test
yuhao900914 92e5ea5
fix: refine the logic
yuhao900914 847d367
test: fix the test
yuhao900914 e411381
fix: refactor move web attribution logic in analytics-client-common
yuhao900914 baff0c6
fix: nits
yuhao900914 7530205
fix: remove await on page view tracking
yuhao900914 b6b2ca3
feat: make setSessionId return promise
yuhao900914 5294eae
test: fix test
yuhao900914 feffbd3
fix: fix the track campaign event
yuhao900914 9c442c8
fix: fix event promise
yuhao900914 fb8630a
fix: add type
yuhao900914 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -907,22 +907,6 @@ describe('integration', () => { | |
| { | ||
| device_id: uuid, | ||
| event_id: 101, | ||
| event_type: 'session_start', | ||
| insert_id: uuid, | ||
| ip: '$remote', | ||
| language: 'en-US', | ||
| library, | ||
| partner_id: undefined, | ||
| plan: undefined, | ||
| platform: 'Web', | ||
| session_id: number, | ||
| time: number, | ||
| user_agent: userAgent, | ||
| user_id: '[email protected]', | ||
| }, | ||
| { | ||
| device_id: uuid, | ||
| event_id: 102, | ||
| event_type: '$identify', | ||
| insert_id: uuid, | ||
| ip: '$remote', | ||
|
|
@@ -980,6 +964,22 @@ describe('integration', () => { | |
| }, | ||
| }, | ||
| }, | ||
| { | ||
| device_id: uuid, | ||
| event_id: 102, | ||
| event_type: 'session_start', | ||
| insert_id: uuid, | ||
| ip: '$remote', | ||
| language: 'en-US', | ||
| library, | ||
| partner_id: undefined, | ||
| plan: undefined, | ||
| platform: 'Web', | ||
| session_id: number, | ||
| time: number, | ||
| user_agent: userAgent, | ||
| user_id: '[email protected]', | ||
| }, | ||
| { | ||
| device_id: uuid, | ||
| event_id: 103, | ||
|
|
@@ -1115,22 +1115,6 @@ describe('integration', () => { | |
| { | ||
| device_id: uuid, | ||
| event_id: 0, | ||
| event_type: 'session_start', | ||
| insert_id: uuid, | ||
| ip: '$remote', | ||
| language: 'en-US', | ||
| library, | ||
| partner_id: undefined, | ||
| plan: undefined, | ||
| platform: 'Web', | ||
| session_id: number, | ||
| time: number, | ||
| user_agent: userAgent, | ||
| user_id: '[email protected]', | ||
| }, | ||
| { | ||
| device_id: uuid, | ||
| event_id: 1, | ||
| event_type: '$identify', | ||
| insert_id: uuid, | ||
| ip: '$remote', | ||
|
|
@@ -1188,6 +1172,22 @@ describe('integration', () => { | |
| }, | ||
| }, | ||
| }, | ||
| { | ||
| device_id: uuid, | ||
| event_id: 1, | ||
| event_type: 'session_start', | ||
| insert_id: uuid, | ||
| ip: '$remote', | ||
| language: 'en-US', | ||
| library, | ||
| partner_id: undefined, | ||
| plan: undefined, | ||
| platform: 'Web', | ||
| session_id: number, | ||
| time: number, | ||
| user_agent: userAgent, | ||
| user_id: '[email protected]', | ||
| }, | ||
| { | ||
| device_id: uuid, | ||
| event_id: 2, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,8 @@ | |
| <title>Amplitude SDK Playground</title> | ||
| </head> | ||
| <script src="./amplitude.js"></script> | ||
| <script> | ||
|
|
||
| <script> | ||
| amplitude.init('API_KEY', '[email protected]'); | ||
| </script> | ||
| <body> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.