-
Notifications
You must be signed in to change notification settings - Fork 54
fix: fix web attribution identify and session start order #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
80a754e to
4aef4a7
Compare
a424fb2 to
cb448e4
Compare
ea65423 to
ff7f12a
Compare
1011316 to
6f25593
Compare
aacb90a to
45aa354
Compare
|
Hey @yuhao900914, since we're affected by this issue, I would like to understand the solution which has been applied. I would appreciate it if you could elaborate on that. |
Hi @omares , Thanks for your support. Previously, fire session end and session start events were bundled together, the web attribution was a plugin, and when to execute the web attribution plugin had a specific order. This makes it impossible to fire a web attribution to identify the call in the middle of the session end and session start event. |
|
@yuhao900914 on the summary, can you please also describe the problem that we are trying to solve? |
e948619 to
ca2214d
Compare
98ce3d6 to
b6b2ca3
Compare
izaaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments but the rest looks good. Thanks @yuhao900914
Summary
Original Issue:
The campaign tracking fired after the session start event, so the session start event won't have the web attribution identify, which led to the Channels related to sessions being wrong.
Related Tickets:
https://amplitude.atlassian.net/browse/AMP-96571
https://amplitude.atlassian.net/browse/AMP-95820
- make setSessionId async and add severalawaitto keep the order.Checklist