Skip to content

Use "e" instead of "b" for opening files, also check that e is a valid file mode #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Luciam91 wants to merge 2 commits into from
Closed

Use "e" instead of "b" for opening files, also check that e is a valid file mode #20

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0069fa
Use "e" instead of "b" for opening files, also check that e is a vali…
Luciam91 Oct 11, 2017
651f632
Removing the mode check on "e" and ensure that binary won't be broken…
Luciam91 Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Internal/FileTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,14 @@ public function run(Environment $environment) {
case "x+":
case "c":
case "c+":
case "e":

@kelunik kelunik Oct 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add e here?

@Luciam91 Luciam91 Oct 11, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've misinterpreted the code here (and expected that e was being passed down, I'll remove :)

break;

default:
throw new \Error("Invalid file mode");
}

$handle = @\fopen($path, $mode . 'b');
$handle = @\fopen($path, $mode . 'e');

@kelunik kelunik Oct 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be be.


if (!$handle) {
$message = 'Could not open the file.';
Expand Down