Use "e" instead of "b" for opening files, also check that e is a valid file mode #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Oct 11, 2017
lib/Internal/FileTask.php
Outdated
| case "x+": | ||
| case "c": | ||
| case "c+": | ||
| case "e": |
Contributor
Author
There was a problem hiding this comment.
I think I've misinterpreted the code here (and expected that e was being passed down, I'll remove :)
kelunik
reviewed
Oct 11, 2017
lib/Internal/FileTask.php
Outdated
| } | ||
|
|
||
| $handle = @\fopen($path, $mode . 'b'); | ||
| $handle = @\fopen($path, $mode . 'e'); |
… by reinstating the "b" flag on the fopen
Member
|
@trowski I guess we should also add that to the blocking driver, right? And I think we should have the same |
Member
|
Manually merged via 271ad2b. Also reflected the changes and mode validation into BlockingDriver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is all that's required for #19?
Happy to add more if there's a requirement :)