Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove httpx from requirements #520

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Remove httpx from requirements #520

merged 3 commits into from
Jun 21, 2023

Conversation

agn-7
Copy link
Contributor

@agn-7 agn-7 commented Jun 20, 2023 •
edited by aminalaee
Loading

removed full installation of starlette as a dependency

closes #519

@agn-7
Update pyproject.toml
503cbd6 
removed full installation of starlette as a dependency
@agn-7 agn-7 mentioned this pull request Jun 20, 2023
Closed
@aminalaee
Copy link
Owner

I think python-multipart is missing in pyproject.toml required dependencies.

And for the httpx, you are right that is needed but in the test dependencies not main dependencies:

sqladmin/pyproject.toml

Line 57 in 1940e54

dependencies = [

@aminalaee aminalaee changed the title Update pyproject.toml Remove httpx from requirements Jun 21, 2023
@aminalaee
Copy link
Owner

Thank you for the PR.

@aminalaee aminalaee merged commit 67a51c8 into aminalaee:main Jun 21, 2023
@aminalaee aminalaee mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dependency installation conflict
2 participants
@agn-7 @aminalaee