Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency installation conflict #519

Closed
agn-7 opened this issue Jun 20, 2023 · 4 comments · Fixed by #520
Closed

dependency installation conflict #519

agn-7 opened this issue Jun 20, 2023 · 4 comments · Fixed by #520

Comments

@agn-7
Copy link
Contributor

agn-7 commented Jun 20, 2023

During the installation of this package using pip I got the following error:

.
.
.
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
googletrans 3.0.0 requires httpx==0.13.3, but you have httpx 0.24.1 which is incompatible.

I think the googletrans PyPI package version is bounded into the setup.py which caused this error. But I couldn't find the setup.py to fix it.

@aminalaee
Copy link
Owner

Hey @agn-7
I think the issue is that sqladmin requires starlette[full] and that requires httpx 22 or newer: https://github.com/encode/starlette/blob/2168e47052239da5df35d5353bb986f760c51cef/pyproject.toml#L41

Its interesting because I think I shouldn't have used starlette[full] here:

"starlette[full]",

Because httpx is not required for sqladmin.

@aminalaee
Copy link
Owner

Feel free to update this in pypronect.toml

@agn-7
Copy link
Contributor Author

agn-7 commented Jun 20, 2023

Thank you for your instant response.

#520

@agn-7
Copy link
Contributor Author

agn-7 commented Jun 20, 2023

But apparently, the starlette[full] was needed as the test cases failed due to the required dependencies like jinja which was in the starlette full dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants