Skip to content

Enable macOS vcpkg triples compilation#3

Merged
GiulioRomualdi merged 5 commits intomasterfrom
feature/add_osx
May 31, 2020
Merged

Enable macOS vcpkg triples compilation#3
GiulioRomualdi merged 5 commits intomasterfrom
feature/add_osx

Conversation

@GiulioRomualdi
Copy link
Copy Markdown
Contributor

No description provided.

@traversaro
Copy link
Copy Markdown
Contributor

Actually the reason why the CI was not starting was a .yml syntax error... sorry for the noise.

@GiulioRomualdi
Copy link
Copy Markdown
Contributor Author

Unfortunately adding osx the compilation time, for windows, lasts more than 6 hours.

@traversaro
Copy link
Copy Markdown
Contributor

Unfortunately adding osx the compilation time, for windows, lasts more than 6 hours.

That is quite strange, the osx build should not influence the Windows build.

@traversaro
Copy link
Copy Markdown
Contributor

Unfortunately adding osx the compilation time, for windows, lasts more than 6 hours.

That is quite strange, the osx build should not influence the Windows build.

The actual error seems to be:

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: C:/ify-deps/vcpkg/downloads/tools/msys2/msys64/usr/bin/bash.exe --noprofile --norc -c "panama -Sy --noconfirm --needed make automake1.15"
    Working Directory: C:/ify-deps/vcpkg/downloads/tools/msys2
    Error code: Access violation
    See logs for more information:
      C:\ify-deps\vcpkg\buildtrees\icu\msys-pacman-x64-windows-static-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_acquire_msys.cmake:108 (vcpkg_execute_required_process)
  ports/icu/portfile.cmake:77 (vcpkg_acquire_msys)
  scripts/ports.cmake:90 (include)

and then the builds hangs there. I suspect we have the same errors without modifications (I opened #4 to check this).

I saw a lot of msys2 related issues and PRs lately in vcpkg, so I think that using a recent vcpkg commit (one after microsoft/vcpkg#11443) should work fine.
Note that probably it make sense to add a scheduled job to GitHub actions so we realize this environment failures before we try to do unrelated changes.

@GiulioRomualdi
Copy link
Copy Markdown
Contributor Author

We may try to use the latest commit: microsoft/vcpkg@6d36e2a

@GiulioRomualdi GiulioRomualdi merged commit 9dfef33 into master May 31, 2020
@GiulioRomualdi GiulioRomualdi deleted the feature/add_osx branch May 31, 2020 17:36
@GiulioRomualdi
Copy link
Copy Markdown
Contributor Author

If you agree I can create the release v0.3.0

@GiulioRomualdi GiulioRomualdi self-assigned this May 31, 2020
@traversaro
Copy link
Copy Markdown
Contributor

If you agree I can create the release v0.3.0

Absolutely yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants