-
Notifications
You must be signed in to change notification settings - Fork 6
Update : img to Next.js Image component and fix one Tailwind syntax e… #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,7 +44,7 @@ const ContactDetails = () => { | |
| initial="initial" | ||
| whileInView="animate" | ||
| viewport={{ once: true }}> | ||
| <img src={data.contact.img} width={155} | ||
| <Image src={data.contact.img} width={155} | ||
| height={155} | ||
| alt="white bulb" /> | ||
|
Comment on lines
+47
to
49
|
||
| </motion.div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,5 @@ | ||||||
| import React from "react"; | ||||||
| import Image from "next/image"; | ||||||
| import Carousel from "react-multi-carousel"; | ||||||
| import "react-multi-carousel/lib/styles.css"; | ||||||
| import "./styles.css"; | ||||||
|
|
@@ -38,7 +39,7 @@ const Slider = ({ sliderImageUrl, showDescription }) => { | |||||
| {sliderImageUrl.map((imageUrl, index) => { | ||||||
| return ( | ||||||
| <div className="slider group" key={index}> | ||||||
| <img src={imageUrl.url} Transition={Blur} loading="lazy"/> | ||||||
| <Image src={imageUrl.url} Transition={Blur} loading="lazy"/> | ||||||
|
||||||
| <Image src={imageUrl.url} Transition={Blur} loading="lazy"/> | |
| <Image src={imageUrl.url} width={imageUrl.width} height={imageUrl.height} Transition={Blur} loading="lazy"/> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,24 +25,24 @@ const memberCard = ({ | |
| <p className="md:text-lg text-xs">{title}</p> | ||
| <div className="flex justify-center lg:mt-10 md:mt-5 mt-1"> | ||
| {githubLink ? <a href={githubLink} target="_blank" rel="noreferrer"> | ||
| <img | ||
| <Image | ||
| src="assets/icons/socials/Vector-3.svg" | ||
| alt="github" | ||
| className="lg:w-8 md:w-6 w-3 lg:h-8 md:h-6 h-3 mx-2" | ||
|
||
| /> | ||
| </a> :null} | ||
| {twitterLink ? <a href={twitterLink} target="_blank" rel="noreferrer"> | ||
| <img | ||
| <Image | ||
| src="assets/icons/socials/Vector-2.svg" | ||
| alt="twitter" | ||
| className="lg:w-8 md:w-6 w-3 lg:h-8 md:h-6 h-3 mx-2" | ||
|
||
| /> | ||
| </a> :null} | ||
| {linkedinLink ? <a href={linkedinLink} target="_blank" rel="noreferrer"> | ||
| <img | ||
| <Image | ||
| src="assets/icons/socials/Vector-4.svg" | ||
| alt="linkedin" | ||
| className="llg:w-8 md:w-6 w-3 lg:h-8 md:h-6 h-3 mx-2" | ||
| className="lg:w-8 md:w-6 w-3 lg:h-8 md:h-6 h-3 mx-2" | ||
|
||
| /> | ||
| </a> :null} | ||
| </div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -76,7 +76,7 @@ const MembersAndAlumni = ({ contentFor }) => { | |||||||||
| > | ||||||||||
| <div className="flex justify-center flex-col items-center"> | ||||||||||
| {showAllMembers ? "See less" : "See more"} | ||||||||||
| <img | ||||||||||
| <Image | ||||||||||
|
||||||||||
| src="/assets/icons/seeMore2.png" | ||||||||||
|
||||||||||
| src="/assets/icons/seeMore2.png" | |
| src="/assets/icons/seeMore2.png" | |
| width={40} | |
| height={40} |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,6 @@ | ||||||
| import React from "react"; | ||||||
| import data from "@/content/team.json"; | ||||||
| import Image from "next/image"; | ||||||
| import {motion} from 'framer-motion' | ||||||
| const teamHero = () => { | ||||||
| const team1Varients={ | ||||||
|
|
@@ -20,7 +21,7 @@ const teamHero = () => { | |||||
| initial="initial" | ||||||
| whileInView="animate" | ||||||
| viewport={{once:true}}> | ||||||
| <img src={data.hero.img} | ||||||
| <Image src={data.hero.img} | ||||||
| className="sm:w-[35rem] max-sm:w-[23rem] max-md:mx-5 sm:h-95" | ||||||
| alt="team" /> | ||||||
|
||||||
| alt="team" /> | |
| alt="team" width={560} height={380} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required 'width' and 'height' props for Next.js Image component. These are required for proper optimization unless using 'fill' prop.