-
Notifications
You must be signed in to change notification settings - Fork 3
Update : img to Next.js Image component and fix one Tailwind syntax e… #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to the amFOSS Dev Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the codebase to use Next.js Image components for better performance optimization and fixes a Tailwind CSS syntax error.
- Replaces all
<img>
tags with Next.js<Image>
components across multiple files - Fixes Tailwind CSS typo from
llg:w-8
tolg:w-8
- Adds necessary Image imports to components that didn't have them
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
components/team/teamHero.jsx | Added Image import and replaced img tag with Image component |
components/team/membersAndAlumni.jsx | Replaced img tag with Image component for "See more" toggle |
components/team/memberCard.jsx | Replaced social media icon img tags with Image components and fixed Tailwind typo |
components/gallery/slider.jsx | Added Image import and replaced img tag in slider component |
components/contact/ContactDetails.jsx | Replaced img tag with Image component for contact illustration |
components/achievements/infiniteSlider.jsx | Added Image import and replaced img tag in infinite slider |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
<div className="flex justify-center flex-col items-center"> | ||
{showAllMembers ? "See less" : "See more"} | ||
<img | ||
<Image |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required 'width' and 'height' props for Next.js Image component. These are required for proper optimization unless using 'fill' prop.
Copilot uses AI. Check for mistakes.
components/team/memberCard.jsx
Outdated
<Image | ||
src="assets/icons/socials/Vector-3.svg" | ||
alt="github" | ||
className="lg:w-8 md:w-6 w-3 lg:h-8 md:h-6 h-3 mx-2" |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required 'width' and 'height' props for Next.js Image component. These are required for proper optimization unless using 'fill' prop.
Copilot uses AI. Check for mistakes.
components/team/memberCard.jsx
Outdated
<Image | ||
src="assets/icons/socials/Vector-2.svg" | ||
alt="twitter" | ||
className="lg:w-8 md:w-6 w-3 lg:h-8 md:h-6 h-3 mx-2" |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required 'width' and 'height' props for Next.js Image component. These are required for proper optimization unless using 'fill' prop.
Copilot uses AI. Check for mistakes.
components/team/memberCard.jsx
Outdated
<Image | ||
src="assets/icons/socials/Vector-4.svg" | ||
alt="linkedin" | ||
className="llg:w-8 md:w-6 w-3 lg:h-8 md:h-6 h-3 mx-2" | ||
className="lg:w-8 md:w-6 w-3 lg:h-8 md:h-6 h-3 mx-2" |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required 'width' and 'height' props for Next.js Image component. These are required for proper optimization unless using 'fill' prop.
Copilot uses AI. Check for mistakes.
components/gallery/slider.jsx
Outdated
return ( | ||
<div className="slider group" key={index}> | ||
<img src={imageUrl.url} Transition={Blur} loading="lazy"/> | ||
<Image src={imageUrl.url} Transition={Blur} loading="lazy"/> |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required 'width' and 'height' props for Next.js Image component. These are required for proper optimization unless using 'fill' prop.
<Image src={imageUrl.url} Transition={Blur} loading="lazy"/> | |
<Image src={imageUrl.url} width={imageUrl.width} height={imageUrl.height} Transition={Blur} loading="lazy"/> |
Copilot uses AI. Check for mistakes.
<img | ||
<Image | ||
src={company.img_path} | ||
alt={company.alt} |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required 'width' and 'height' props for Next.js Image component. These are required for proper optimization unless using 'fill' prop.
alt={company.alt} | |
alt={company.alt} | |
width={176} | |
height={176} |
Copilot uses AI. Check for mistakes.
@MaelBallereau I noticed that some Please update your PR accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
<img src={data.hero.img} | ||
<Image src={data.hero.img} | ||
className="sm:w-[35rem] max-sm:w-[23rem] max-md:mx-5 sm:h-95" | ||
alt="team" /> |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next.js Image component requires width and height props for proper optimization. Add explicit width and height attributes or use the fill prop with a positioned parent container.
alt="team" /> | |
alt="team" width={560} height={380} /> |
Copilot uses AI. Check for mistakes.
{showAllMembers ? "See less" : "See more"} | ||
<img | ||
<Image | ||
src="/assets/icons/seeMore2.png" |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next.js Image component requires width and height props for proper optimization. Add explicit width and height attributes based on the w-10 h-10 classes (40px each).
src="/assets/icons/seeMore2.png" | |
src="/assets/icons/seeMore2.png" | |
width={40} | |
height={40} |
Copilot uses AI. Check for mistakes.
<Image src={data.contact.img} width={155} | ||
height={155} | ||
alt="white bulb" /> |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing import statement for the Image component. Add 'import Image from "next/image";' at the top of the file.
Copilot uses AI. Check for mistakes.
I think its ok now |
@MaelBallereau Seems like the responsiveness got broken The first image is from your PR branch and the second one is from amfoss.in for reference. Please ensure all the updated components are responsive. |
Fix Tailwind syntax and replace
<img />
with Next.js Image componentllg:w-8
tolg:w-8
.