[foxy backport] Increase the ament_cppcheck timeout to 5 minutes. (#271)#277
Merged
jacobperron merged 1 commit intoament:foxyfrom Nov 6, 2020
Merged
Conversation
This will avoid timeouts on some slower platforms that we've started to see. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Author
|
Example of failure:
|
jacobperron
approved these changes
Nov 6, 2020
Contributor
|
@brawner the referenced example failure doesn't appear to be related. |
Author
|
Oh weird, I ran into the error 3x in a row. I was certain it would happen again. This is an example of the error |
Author
|
The timeout issue was resolved, but now there is a warning due to a recent commit to Fast-dds. I opened a PR for that issue at eProsima/Fast-DDS#1558 |
Author
|
It looks like cppcheck took 3 minutes and 40 seconds to run, so 5 minute timeout looks about right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will avoid timeouts on some slower platforms that we've
started to see.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org