Increase the ament_cppcheck timeout to 5 minutes.#271
Merged
clalancette merged 1 commit intomasterfrom Sep 8, 2020
Merged
Conversation
This will avoid timeouts on some slower platforms that we've started to see. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
wjwwood
approved these changes
Sep 8, 2020
Contributor
wjwwood
left a comment
wjwwood
left a comment
There was a problem hiding this comment.
Sounds good to me, stability is worth the trade off of potentially waiting longer if it hangs.
Contributor
Author
|
Thanks, appreciate the review. Merging. |
delete-merged-branch
bot
deleted the
clalancette/cppcheck-increase-timeout
branch
brawner
pushed a commit
to brawner/ament_lint
that referenced
this pull request
Nov 6, 2020
This will avoid timeouts on some slower platforms that we've started to see. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
pushed a commit
that referenced
this pull request
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will avoid timeouts on some slower platforms that we've
started to see.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This fixes ros2/rclcpp#1289