-
Notifications
You must be signed in to change notification settings - Fork 7
WIP: feat(versionpage): added version page for static and SSR #190
base: master
Are you sure you want to change the base?
Conversation
FYI to add branch info, this is the code at a minimum I would need to add. This gets the branch name:
|
There's an NPM module that makes it easy to get the details without having to parse them from the filesystem yourself: |
@amclin as long as you sign off on it i have no issue using that. so i'll use that one. |
@KevinDanikowski yes, please use a library for reading git properties. Also, let's be careful about displaying environment variables, as protected values like security tokens may come from the environment. It would be better to only explicitly list specific properties. |
Currently using I'm ok with either using 1 library with multiple git functions, or a library per function if they're single-function libraries |
added version page Fixes #108