Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

add version page #108

Open
KevinDanikowski opened this issue Nov 22, 2019 · 4 comments · May be fixed by #190
Open

add version page #108

KevinDanikowski opened this issue Nov 22, 2019 · 4 comments · May be fixed by #190
Labels
enhancement New feature or request

Comments

@KevinDanikowski
Copy link

Add a version page that works with environmental settings so that it is a page accessible from a /version route or soething similar which displays the version, deployment date, APP_ENV, etc.

Should be able to add a version.js file located in the pages directory. Add a note at the top of the file that states what the purpose is. See an example api file here https://reacttricks.com/exploring-next-9-dynamic-routing-and-api-routes/

@amclin amclin added the enhancement New feature or request label Nov 22, 2019
@amclin
Copy link
Owner

amclin commented Nov 22, 2019

This could make a great API example, but then it would only be available in the SSR version of generated projects.

@KevinDanikowski
Copy link
Author

@amclin Why do you want to have two versions, one with SSR and one without?

@amclin
Copy link
Owner

amclin commented Nov 25, 2019

@KevinDanikowski I'd rather not have 2 versions, but if it's going to display runtime environment variables, then that would justify an SSR version.

@KevinDanikowski
Copy link
Author

@amclin ok I believe I understand what you're saying now. I believe my comment in the enivornmental issue clarifies this. I am supposed to use the publicRuntimeConfig to access what ever the run time environmental variables are. Would this not accomplish what the version page is designed to do?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants