Skip to content

Crystal 0.27.0#973

Merged
drujensen merged 5 commits into
masterfrom
dj/crystal-0-27-0
Nov 4, 2018
Merged

Crystal 0.27.0#973
drujensen merged 5 commits into
masterfrom
dj/crystal-0-27-0

Conversation

@drujensen
Copy link
Copy Markdown
Member

Description of the Change

Fix breaking changes in Crystal 0.27.0

https://crystal-lang.org/2018/11/01/crystal-0.27.0-released.html#files-changes

Alternate Designs

N/A

Benefits

Support latest version of Crystal

Possible Drawbacks

N/A

@drujensen
Copy link
Copy Markdown
Member Author

drujensen commented Nov 3, 2018

Needs a fix for Crecto for specs to pass

Waiting for Crecto/crecto#225

@drujensen
Copy link
Copy Markdown
Member Author

drujensen commented Nov 4, 2018

Had to add some types Int8 and Int16 to the jasper helpers. I did a release 0.2.1 to fix the issue.

Anyone around that can review this?

@elorest Once this is merged, can you do a release?

Copy link
Copy Markdown
Member

@elorest elorest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. TNX.

Merge and I'll get it released soon. Having an early Thanks Giving with one side of my family, but I'll get it done today or tomorrow.

@drujensen drujensen merged commit 5c68626 into master Nov 4, 2018
@drujensen drujensen deleted the dj/crystal-0-27-0 branch November 4, 2018 16:45
@drujensen
Copy link
Copy Markdown
Member Author

@elorest thanks for reviewing. merged and ready to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants