Skip to content

Ensure compatibility with crystal 0.27.0#972

Closed
waghanza wants to merge 1 commit into
amberframework:masterfrom
waghanza:crystal_0.27.0
Closed

Ensure compatibility with crystal 0.27.0#972
waghanza wants to merge 1 commit into
amberframework:masterfrom
waghanza:crystal_0.27.0

Conversation

@waghanza
Copy link
Copy Markdown

@waghanza waghanza commented Nov 3, 2018

Hi,

According to https://github.com/crystal-lang/crystal/blob/master/CHANGELOG.md, there is some breaking change in crystal.

This PR is a starting point for compatibility.

Tempfile does not exists anymore, file.tempfile is used instead
crystal-lang/crystal#6485

Regards,

@waghanza
Copy link
Copy Markdown
Author

waghanza commented Nov 3, 2018

@faustinoaq for me the next error is due to crystal-lang/crystal#6514, but I don't if this is from teeplate or from amber

@drujensen
Copy link
Copy Markdown
Member

drujensen commented Nov 3, 2018

@waghanza thanks for this. I opened a new PR that includes all the needed changes #973. We are waiting for a Crecto update for the final specs to pass.

@drujensen drujensen closed this Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants