Skip to content

Update to crystal 0.26 #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcardiff wants to merge 1 commit into from
Closed

Update to crystal 0.26 #922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/amber/cli/commands/exec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ module Amber::CLI

class Exec < Command
command_name "exec"
@filename : String = "./tmp/#{Time.now.epoch_ms}_console.cr"
@filelogs : String = @filename.sub("console.cr", "console_result.log")
@filename : String
@filelogs : String

def initialize(__previous, __argv)
Copy link
Copy Markdown
Contributor

@Sija Sija Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use *args and super?

Copy link
Copy Markdown
Contributor Author

@bcardiff bcardiff Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the minimum change. But it should be equivalent.

@filename = "./tmp/#{Time.now.epoch_ms}_console.cr"
@filelogs = @filename.sub("console.cr", "console_result.log")
super(__previous, __argv)
end

class Options
arg "code", desc: "Crystal code or .cr file to execute within the application scope", default: ""
Expand Down