Closed
Conversation
Sija
reviewed
Aug 8, 2018
| @filename : String | ||
| @filelogs : String | ||
|
|
||
| def initialize(__previous, __argv) |
Contributor
Author
There was a problem hiding this comment.
It was the minimum change. But it should be equivalent.
Contributor
|
Also, there's one more: |
Contributor
Author
|
I didn't detect that because building the specs does not stress that path 🤔 . To fix that, either something like kemalcr/kemal#477 can be done, or |
Contributor
Author
|
I also noticed that the shell-table shard version will need to be updated to support 0.26.0 jwaldrip/shell-table.cr#2 |
4 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This changes should be backward compatible with 0.25.1
Ref: crystal-lang/crystal#6414
ivar initializers will be evaluated without
selfin context.Disclaimer: I've only checked that the source build with crystal nightly together with this patch.