Skip to content

Remove Granite.settings.logger from spec #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faustinoaq merged 17 commits into from
Jun 20, 2018
+3 −1
Merged

Remove Granite.settings.logger from spec #816

Changes from 8 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2777db1
Remove Granite.settings.logger from spec
faustinoaq May 26, 2018
380f094
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq May 27, 2018
7657b6c
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq May 27, 2018
29e9cf3
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq May 27, 2018
7d9b9df
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq May 31, 2018
31f4aae
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq Jun 1, 2018
e383331
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq Jun 12, 2018
e244013
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq Jun 12, 2018
fd57f85
Merge branch 'master' into fa/fix-crecto-spec
eliasjpr Jun 13, 2018
9f0642c
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq Jun 14, 2018
6deaf81
Add spec_helper template
faustinoaq Jun 16, 2018
0b14b50
Merge branch 'fa/fix-crecto-spec' of github.com:amberframework/amber …
faustinoaq Jun 16, 2018
d6586d1
Remove spaces and add comment
faustinoaq Jun 16, 2018
dff34d9
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq Jun 16, 2018
21d5bba
Merge branch 'master' into fa/fix-crecto-spec
faustinoaq Jun 20, 2018
b9a9eb3
Use instance var
faustinoaq Jun 20, 2018
5faccd9
Merge branch 'fa/fix-crecto-spec' of github.com:amberframework/amber …
faustinoaq Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/amber/cli/templates/app/spec/spec_helper.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ Micrate::DB.connection_url = Amber.settings.database_url
# Automatically run migrations on the test database
Micrate::Cli.run_up

# Disable query logger for tests
Granite.settings.logger = Logger.new nil

@veelenga veelenga May 27, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can set it dynamically? Take a look here

@faustinoaq faustinoaq May 27, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veelenga yeah, but I think Granite logs are very useful, you can see query time and raw sql information, these logs helped me to fix some issues on Amber itself 😅

@robacarp robacarp May 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to leave it disabled because it generates so much noise. A verbose query log makes it hard to tell what happens when a test is failing. When tests all pass, the output of the suite should be minimal, indicating that nothing unexpected happened.

@faustinoaq faustinoaq May 31, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robacarp Crecto spec fails because granite dependency is missing on crecto projects. Maybe we should use a spec_helper.cr.ecr template as well, like this:

<%- if database == "granite" %>
Granite.settings.logger = Logger.new nil
<% end %>

WDYT?

@robacarp robacarp Jun 6, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faustinoaq yes, thats a good idea.

@robacarp robacarp Jun 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faustinoaq what happened here? Did the idea for the conditional get scrapped?

@faustinoaq faustinoaq Jun 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robacarp Yeah, let me add this conditional code 👍

@faustinoaq faustinoaq Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 👍

module Spec
DRIVER = :chrome
PATH = "/usr/local/bin/chromedriver"
Expand Down