Remove Granite.settings.logger from spec

[faustinoaq]

Description of the Change

This PR removes Granite.settings.logger from spec because causes compilation error on projects generated with -m crecto

Alternate Designs

Use spec_helper.cr.ecr template

Benefits

Print query logs (very useful for debugging specs)
Fix crystal spec on projects generated with -m crecto

Possible Drawbacks

No

[veelenga]

Maybe we can set it dynamically? Take a look here

[faustinoaq]

@veelenga yeah, but I think Granite logs are very useful, you can see query time and raw sql information, these logs helped me to fix some issues on Amber itself 😅

[robacarp]

I'd prefer to leave it disabled because it generates so much noise. A verbose query log makes it hard to tell what happens when a test is failing. When tests all pass, the output of the suite should be minimal, indicating that nothing unexpected happened.

[faustinoaq]

@robacarp Crecto spec fails because granite dependency is missing on crecto projects. Maybe we should use a spec_helper.cr.ecr template as well, like this:

<%- if database == "granite" %>
Granite.settings.logger = Logger.new nil
<% end %>

WDYT?

[robacarp]

@faustinoaq yes, thats a good idea.

[robacarp]

@faustinoaq what happened here? Did the idea for the conditional get scrapped?

[faustinoaq]

@robacarp Yeah, let me add this conditional code 👍

[faustinoaq]

Done! 👍

[eliasjpr]

I think instead of removing the logger for Granite we should render the right logger for the right ORM WDYT?

[faustinoaq]

@eliasjpr Yeah, I'm already fixing this 👍

Edit: Done 🎉 !

[faustinoaq]

Required by #850

[faustinoaq]

@robacarp for some reason this is still generating Granite logs, any idea?

I checked twice and spec_helper.cr is generated with the code to disable logs, Are we enabling logs in some other file? maybe in some initializer?

Ref: https://travis-ci.org/amberframework/amber/jobs/394384754#L736

[faustinoaq]

Opened tracking issue here: #885