Initial localization implementation #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haomingli2020
requested review from
chauhuynh97 and
mrajatttt
and removed request for
a team
haomingli2020
force-pushed
the
haominli/localization
branch
from
618e8f0 to
e6ebf2d
Compare
haomingli2020
changed the title
chauhuynh97
reviewed
Apr 10, 2024
| render(<ThemeProvider> | ||
| <Chat {...mockProps} /> | ||
| </ThemeProvider>); | ||
| render(<IntlProvider onError={jest.fn} locale="en"> |
There was a problem hiding this comment.
qq: does IntlProvider onError={jest.fn} locale="en" forces the language to be English or does it translate from whatever language back to English?
There was a problem hiding this comment.
In unit test it forces the language to be English.
chauhuynh97
approved these changes
Apr 10, 2024
mhiaror
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#61
Description of changes:
Initial localization implementation
react-intlfor localizationFormattedMessagefor below textscloseandend chattype a messageplaceholderTesting:
Screen.Recording.2024-04-10.at.1.13.01.PM.mov
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.