Skip to content

Select columns from dataframe using a list #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Select columns from dataframe using a list #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0ff335
Select columns from dataframe using a list
CJStadler Jun 20, 2019
ad3f683
Update changelog
CJStadler Jun 20, 2019
237892c
Update changelog
CJStadler Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/source/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@ Changelog
**Future Release**
* Enhancements
* Fixes
* Change type of features calculated on Index features to Categorical (:pr:`602`)
* Select columns of dataframe using a list (:pr:`615`)
* Change type of features calculated on Index features to Categorical (:pr:`602`)
* Changes
* Documentation Changes
* Testing Changes

Thanks to the following people for contributing to this release:
:user:`CJStadler`

**v0.9.0** June 19, 2019
* Enhancements
Expand Down
6 changes: 3 additions & 3 deletions featuretools/computational_backends/feature_set_calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,11 +617,11 @@ def _necessary_columns(self, entity, feature_names):
if isinstance(v, (variable_types.Index,
variable_types.Id,
variable_types.TimeIndex))}
features = [self.feature_set.features_by_name[name]
for name in feature_names]
features = (self.feature_set.features_by_name[name]
for name in feature_names)
Copy link
Contributor Author

@CJStadler CJStadler Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was creating a list unnecessarily, not related to the issue here.

feature_columns = {f.variable.id for f in features
if isinstance(f, IdentityFeature)}
return index_columns | feature_columns
return list(index_columns | feature_columns)


def _can_agg(feature):
Expand Down