Select columns from dataframe using a list #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the columns were in a set, but this doesn not work on pandas 0.23.
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 119 119
Lines 9666 9666
=======================================
Hits 9313 9313
Misses 353 353
Continue to review full report at Codecov.
|
CJStadler
commented
Jun 20, 2019
| features = [self.feature_set.features_by_name[name] | ||
| for name in feature_names] | ||
| features = (self.feature_set.features_by_name[name] | ||
| for name in feature_names) |
Contributor
Author
There was a problem hiding this comment.
This was creating a list unnecessarily, not related to the issue here.
This was referenced Jun 25, 2019
Merged
johnnyheineken
pushed a commit
to johnnyheineken/featuretools
that referenced
this pull request
Jul 7, 2019
* Select columns from dataframe using a list Previously the columns were in a set, but this doesn not work on pandas 0.23. * Update changelog * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the columns were in a set, but this does not work on pandas 0.23.
Fixes #614