ISSUE 220 - Remove unused CSS 'govuk-button' class from the 'search' submit button #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqbalgds
force-pushed
the
issue-220-fix-remove-class-from-search-submit-button
branch
from
068da59 to
fa194f3
Compare
36degrees
reviewed
Mar 24, 2021
lib/govuk_tech_docs/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module GovukTechDocs | |||
| VERSION = "2.2.1".freeze | |||
| VERSION = "2.2.2".freeze | |||
There was a problem hiding this comment.
I think we tend to do releases separately in this repo, rather than making a change and releasing in the same PR.
There was a problem hiding this comment.
Thanks - will update
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## 2.2.2 | |||
|
|
|||
| - [#218: Remove unnecessary CSS class on the search submit button](https://github.com/alphagov/tech-docs-gem/pull/223) | |||
There was a problem hiding this comment.
Suggested change
| - [#218: Remove unnecessary CSS class on the search submit button](https://github.com/alphagov/tech-docs-gem/pull/223) | |
| - [#223: Remove unnecessary CSS class on the search submit button](https://github.com/alphagov/tech-docs-gem/pull/223) |
iqbalgds
force-pushed
the
issue-220-fix-remove-class-from-search-submit-button
branch
from
fa194f3 to
3be232f
Compare
…submit button - The 'search' submit button had the un-necessary CSS class 'govuk-button'. - It a someone uses the gem and they are importing the Design System 'govuk-button' CSS stylesheet, then it breaks the styling on the button.
iqbalgds
force-pushed
the
issue-220-fix-remove-class-from-search-submit-button
branch
from
3be232f to
3d17fbc
Compare
36degrees
reviewed
Mar 25, 2021
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## 2.2.2 | |||
There was a problem hiding this comment.
This should be 'Unreleased' until a new version is released (which might be 2.2.2, but could equally be 2.3) – it also makes it clear to users looking at the changelog that these changes haven't gone out yet.
richardTowers
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Looks good to me (although I agree with @36degrees about the title in the changelog, so you should probably fix that before merging 😄)
iqbalgds
deleted the
issue-220-fix-remove-class-from-search-submit-button
branch
kr8n3r
added a commit
to alphagov/paas-tech-docs
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
then it breaks the styling on the button.