Skip to content

Commit

Permalink
ISSUE 220 - Remove unused CSS 'govuk-button' class from the 'search' …
Browse files Browse the repository at this point in the history
…submit button

- The 'search' submit button had the un-necessary CSS class 'govuk-button'.
- It a someone uses the gem and they are importing the Design System 'govuk-button' CSS stylesheet,
  then it breaks the styling on the button.
  • Loading branch information
iqbalgds committed Mar 24, 2021
1 parent 9553bfd commit 3d17fbc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 2.2.2

- [#223: Remove unnecessary CSS class on the search submit button](https://github.com/alphagov/tech-docs-gem/pull/223)

## 2.2.1

- [#218: Remove unnecessary explicit dependencies: sprockets, activesupport, sass and pry](https://github.com/alphagov/tech-docs-gem/pull/218)
Expand Down
2 changes: 1 addition & 1 deletion lib/source/layouts/_search.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
class="govuk-input govuk-!-margin-bottom-0 search__input"
aria-controls="search-results"
placeholder="Search">
<button type="submit" class="govuk-button search__button">Search</button>
<button type="submit" class="search__button">Search</button>
</form>
<div id="search-results" class="search-results" aria-hidden="true" role="dialog" aria-labelledby="search-results-title">
<div class="search-results__inner">
Expand Down

0 comments on commit 3d17fbc

Please sign in to comment.