Add links to all roles to worldwide organisation content item #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app. See also alphagov/whitehall#8162 and alphagov/government-frontend#2906.
jkempster34
force-pushed
the
add-all-roles-to-ww-org
branch
from
043640c to
567b5f5
Compare
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Aug 24, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app. See also alphagov/publishing-api#2478 and alphagov/government-frontend#2906.
jkempster34
added a commit
to alphagov/government-frontend
that referenced
this pull request
Aug 24, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the worldwide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app. See also alphagov/publishing-api#2478 and alphagov/whitehall#8162.
CristinaRO
approved these changes
Aug 24, 2023
|
I've approved the general approach. It's similar to how we solved the multiple roles on the Ministers page, too. I noticed that usually links include |
Thank you! I don't think there is any order needed here tbh, they are just being published in whatever the default order is. |
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Aug 25, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app. See also alphagov/publishing-api#2478 and alphagov/government-frontend#2906.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/54I3mDxr
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages.
This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app.
See also alphagov/whitehall#8162 and alphagov/government-frontend#2906.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.