Filter roles to the organisation #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrucadu
force-pushed
the
filter-allowed-roles
branch
from
21e1b23 to
c435b9b
Compare
barrucadu
force-pushed
the
filter-allowed-roles
branch
from
c435b9b to
5186ea1
Compare
This relates to the same problem that was fixed in #1718. Because we're linking to the people, rather than to the role appointments directly, it's possible that link expansion will include information about roles not associated with the organisation. We need to filter those out by using the `ordered_roles` link to ensure the role belongs to the organisation.
barrucadu
force-pushed
the
filter-allowed-roles
branch
from
5186ea1 to
24aa4ae
Compare
barrucadu
approved these changes
May 6, 2020
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Aug 23, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app.
jkempster34
added a commit
to alphagov/publishing-api
that referenced
this pull request
Aug 23, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Aug 23, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app.
jkempster34
added a commit
to alphagov/government-frontend
that referenced
this pull request
Aug 24, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app.
jkempster34
added a commit
to alphagov/publishing-api
that referenced
this pull request
Aug 24, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app. See also alphagov/whitehall#8162 and alphagov/government-frontend#2906.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Aug 24, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app. See also alphagov/publishing-api#2478 and alphagov/government-frontend#2906.
jkempster34
added a commit
to alphagov/government-frontend
that referenced
this pull request
Aug 24, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the worldwide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app. See also alphagov/publishing-api#2478 and alphagov/whitehall#8162.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Aug 25, 2023
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages. This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app. See also alphagov/publishing-api#2478 and alphagov/government-frontend#2906.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to the same problem that was fixed in #1718. Because we're linking to the people, rather than to the role appointments directly, it's possible that link expansion will include information about roles not associated with the organisation. We need to filter those out by using the
ordered_roleslink to ensure the role belongs to the organisation.Trello Card